Page MenuHomePhorge

Hide Archived Panels from Dashboards
ClosedPublic

Authored by valerio.bozzolan on Jul 31 2023, 10:32.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 12, 06:42
Unknown Object (File)
Wed, Jun 12, 01:05
Unknown Object (File)
Mon, Jun 10, 04:17
Unknown Object (File)
Sun, Jun 9, 15:45
Unknown Object (File)
Thu, Jun 6, 18:13
Unknown Object (File)
Fri, May 31, 20:29
Unknown Object (File)
Thu, May 30, 09:01
Unknown Object (File)
Thu, May 30, 09:01

Details

Summary

In edit mode, Archived Panels are shown differently,
with content text in grey and with the usual red tag.

In view mode, Archived Panels are just not rendered.

This makes it easier to design Dashboards with individual
components that can be de-activated and re-activated on the fly.

Closes T15366.

After Archived Panel.png (549×657 px, 34 KB)

Test Plan

Have a Dashboard somewhere (e.g in your homepage).

Visit a Panel (W-ID) and Archive it.

See that now the Panel is not shown anymore on the Dashboard.

Edit the Dashboard and you see the Panel again as "Archived".

Anything around is just normal.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

webroot/rsrc/css/phui/phui-list.css
71

The color was copied from here.

avivey subscribed.

LGTM, except for the comment text.

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php
23–24
This revision is now accepted and ready to land.Aug 1 2023, 07:38