avivey retitled this revision from Unify type-checking for `setHref()` type methods to (phorge) Unify type-checking for `setHref()` type methods.Jul 24 2023, 13:25

avivey mentioned this in D25356: (arc) Unify type-checking for `setHref()` type methods.Jul 24 2023, 19:32

avivey mentioned this in rARC6c6f47bf9cf6: (arc) Unify type-checking for `setHref()` type methods.Jul 24 2023, 19:34

valerio.bozzolan added inline comments.Jul 26 2023, 06:56

src/view/phui/PHUITagView.php
106

valerio.bozzolan retitled this revision from (phorge) Unify type-checking for `setHref()` type methods to Unify type-checking for `setHref()` type methods.Jul 26 2023, 06:58

valerio.bozzolan edited the summary of this revision. (Show Details)

+1 with just that inline suggestion

Thanks

This revision is now accepted and ready to land.Aug 2 2023, 16:34

Closed by commit rPbcfcd9acfc12: Unify type-checking for `setHref()` type methods. · Explain WhyAug 12 2023, 15:39

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rPbcfcd9acfc12: Unify type-checking for `setHref()` type methods.