Page MenuHomePhorge
Feed Advanced Search

Sun, May 28

aklapper added a revision to T15403: Fix "Amazon" icon on Phorge OAuth: D25255: Correct Phorge icon on Auth Provider page.
Sun, May 28, 14:51 · Phorge
aklapper added a comment to T15403: Fix "Amazon" icon on Phorge OAuth.

getLoginIcon() { return PlatformSymbols::getPlatformServerName(); } returns Phorge.
Thus no corresponding icon is found as Phorge.png does not exist and code falls back to first icon.

Sun, May 28, 14:51 · Phorge

Fri, May 26

valerio.bozzolan updated the task description for T15121: Contributor Agreement.
Fri, May 26, 13:43 · Phorge

Thu, May 25

valerio.bozzolan added a comment to T15121: Contributor Agreement.

OK just to have a stub somewhere to start with, please feel free to edit this page:

Thu, May 25, 08:45 · Phorge

Tue, May 23

valerio.bozzolan added a comment to T15121: Contributor Agreement.

A quick thing we can do: creating a Legalpad to accept (in a more explicit way) the terms of the Apache 2.0.

Tue, May 23, 14:57 · Phorge
siepkes added a comment to T15121: Contributor Agreement.

There is a blog post from Bryan Cantrill about why Node.js stopped using CLA's which might be of interest: Broadening Node.js Contributions.

Tue, May 23, 10:53 · Phorge

Mon, May 22

valerio.bozzolan added a comment to T15022: Legal stuff.

A big bug we have now is the absence of a free license in the footer.

Mon, May 22, 09:19 · Phorge
valerio.bozzolan updated the task description for T15022: Legal stuff.
Mon, May 22, 09:15 · Phorge
valerio.bozzolan edited the content of Welcome.
Mon, May 22, 09:12 · Phorge

Fri, May 19

valerio.bozzolan updated the task description for T15403: Fix "Amazon" icon on Phorge OAuth.
Fri, May 19, 12:18 · Phorge
valerio.bozzolan triaged T15403: Fix "Amazon" icon on Phorge OAuth as Normal priority.
Fri, May 19, 12:14 · Phorge

Tue, May 9

aklapper added a comment to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php).

This is not triggered for {{{a}}} a or with a a {{{a}}} a, only for 1 string in front of a string with three squares.

Tue, May 9, 12:17 · Bug Reports, Affects-Wikimedia
aklapper created T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php).
Tue, May 9, 12:14 · Bug Reports, Affects-Wikimedia
valerio.bozzolan added a comment to T15121: Contributor Agreement.

(I think this is a sub-task of T15022)

Tue, May 9, 10:48 · Phorge
valerio.bozzolan added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.

Premising that very probably a fix there would not 100% resolve that upstream issue but surely this deserves a fix :D

Tue, May 9, 08:05 · Bug Reports, Remarkup, Affects-Wikimedia
valerio.bozzolan added a project to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing: Remarkup.
Tue, May 9, 08:03 · Bug Reports, Remarkup, Affects-Wikimedia
valerio.bozzolan added a project to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing: Affects-Wikimedia.
Tue, May 9, 08:02 · Bug Reports, Remarkup, Affects-Wikimedia
aklapper created T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.
Tue, May 9, 07:52 · Bug Reports, Remarkup, Affects-Wikimedia

Mon, May 8

aklapper closed T15362: PHP 8.1 "strlen(null)" exceptions block rendering page to import ICS calendar file as Resolved by committing rP8d2b481bb5a8: Fix PHP 8.1 "strlen(null)" exceptions which block rendering page to import ICS….
Mon, May 8, 21:13 · PHP 8 support
aklapper closed T15365: PHP 8.1 "strlen(null)" exception blocks rendering error pages for Packages' Create Package and Fund's Create Initiative, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 8, 19:43 · PHP 8 support
aklapper closed T15365: PHP 8.1 "strlen(null)" exception blocks rendering error pages for Packages' Create Package and Fund's Create Initiative as Resolved by committing rP1b08be518ef6: Fix PHP 8.1 "strlen(null)" exception which blocks rendering error pages for….
Mon, May 8, 19:43 · PHP 8 support
aklapper closed T15363: PHP 8.1 "strlen(null)" exception blocks rendering Phortune account page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 8, 12:36 · PHP 8 support
aklapper closed T15363: PHP 8.1 "strlen(null)" exception blocks rendering Phortune account page as Resolved by committing rP25e93501c39e: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Phortune account….
Mon, May 8, 12:36 · PHP 8 support
aklapper closed T15360: PHP 8.1 "strlen(null)" exception blocks rendering a project's page when Reports prototype enabled, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 8, 12:35 · PHP 8 support
aklapper closed T15359: PHP 8.1 "ltrim(null)" exception blocks rendering five applications' Configure pages, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 8, 12:33 · PHP 8 support
aklapper closed T15358: PHP 8.1 "strlen(null)" exception blocks rendering most projects' Configure pages, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 8, 11:23 · PHP 8 support
aklapper closed T15357: PHP 8.1 "strlen(null)" exception blocks creating a blog post, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 8, 11:20 · PHP 8 support
aklapper closed T15356: PHP 8.1 "strlen(null)" exception blocks rendering a blog, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 8, 11:19 · PHP 8 support
aklapper closed T15355: PHP 8.1 "strlen(null)" exception blocks blog creation, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 8, 11:18 · PHP 8 support
valerio.bozzolan updated the task description for T15121: Contributor Agreement.
Mon, May 8, 09:36 · Phorge
avivey raised the priority of T15121: Contributor Agreement from High to Unbreak Now!.

This discussion (and disagreement) is exactly the reason why we need a CLA ASAP.
While consulting with a relevant legal counsel.

Mon, May 8, 09:27 · Phorge
valerio.bozzolan added a comment to T15121: Contributor Agreement.

Just some probably interesting notes :D

Mon, May 8, 09:23 · Phorge

Sun, May 7

speck added a comment to T15121: Contributor Agreement.

Many people, myself included, contribute to open source projects under the assumption that my contributions will help serve a project which continues to be open source in perpetuity, and a CLA provides a means for the project maintainers to circumvent that.

Assumption here is key. The entire purpose of a CLA is to remove this assumption and clarify how contributions are managed. This post and disposition is based entirely around the organization receiving contributions will behave in an adversarial manner in the future. If the organization doesn't earn your trust then why trust them with your contributions?

Sun, May 7, 16:37 · Phorge
aklapper closed T15353: PHP 8.1 "strlen(null)" exception blocks rendering Pholio mock preview, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Sun, May 7, 10:37 · PHP 8 support

Sat, May 6

aklapper added a revision to T15365: PHP 8.1 "strlen(null)" exception blocks rendering error pages for Packages' Create Package and Fund's Create Initiative: D25202: Fix PHP 8.1 "strlen(null)" exception which blocks rendering error pages for Packages' Create Package and Fund's Create Initiative.
Sat, May 6, 23:13 · PHP 8 support
aklapper created T15365: PHP 8.1 "strlen(null)" exception blocks rendering error pages for Packages' Create Package and Fund's Create Initiative.
Sat, May 6, 23:12 · PHP 8 support
aklapper added a revision to T15363: PHP 8.1 "strlen(null)" exception blocks rendering Phortune account page: D25201: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Phortune account page.
Sat, May 6, 22:59 · PHP 8 support
aklapper created T15363: PHP 8.1 "strlen(null)" exception blocks rendering Phortune account page.
Sat, May 6, 22:58 · PHP 8 support
aklapper added a revision to T15362: PHP 8.1 "strlen(null)" exceptions block rendering page to import ICS calendar file: D25200: Fix PHP 8.1 "strlen(null)" exceptions which block rendering page to import ICS calendar file.
Sat, May 6, 22:52 · PHP 8 support
aklapper created T15362: PHP 8.1 "strlen(null)" exceptions block rendering page to import ICS calendar file.
Sat, May 6, 22:50 · PHP 8 support
aklapper updated the task description for T15361: PHP 8.1 "explode(null)" exception blocks rendering the Multimeter page.
Sat, May 6, 22:38 · PHP 8 support
aklapper created T15361: PHP 8.1 "explode(null)" exception blocks rendering the Multimeter page.
Sat, May 6, 22:36 · PHP 8 support
bfs added a comment to T15121: Contributor Agreement.
In T15121#8063, @avivey wrote:

Any contribution to Phorge is implicitly covered by Apache 2.0, which allows re-licensing by anyone.
The CLA is only making this explicit.

Sat, May 6, 19:43 · Phorge
valerio.bozzolan closed T15306: Fix Call to phutil_nonempty_string() expected null or a string, got: PhutilURI from PHUIObjectItemView.php:662, a subtask of T15264: Numerous PHP 8.1 "strlen(null)" exceptions preventing homepage to display after installation, as Resolved.
Sat, May 6, 13:57 · PHP 8 support
valerio.bozzolan closed T15306: Fix Call to phutil_nonempty_string() expected null or a string, got: PhutilURI from PHUIObjectItemView.php:662 as Resolved by committing rPe9e2c954132c: Fix regression in PHUIObjectItemView.php:662: allow PhutilURI and other….
Sat, May 6, 13:57 · Bug Reports, PHP 8 support
valerio.bozzolan lowered the priority of T15121: Contributor Agreement from Unbreak Now! to High.
Sat, May 6, 12:36 · Phorge
valerio.bozzolan added a comment to T15121: Contributor Agreement.

Sorry if this unrelated, but this is an interesting partially-related commit:

Sat, May 6, 12:32 · Phorge
valerio.bozzolan added a comment to T15121: Contributor Agreement.

Make sure Phorge is not hit by legal action because of your contribution

Sat, May 6, 12:28 · Phorge
aklapper created T15354: Exception when trying to create Pholio mock without name.
Sat, May 6, 10:03
avivey added a comment to T15030: Support a Phorge Extensions ecosystem.

Rust Conduit Client/R4 is the first project in Phactory!

Sat, May 6, 08:12 · Phactory: Community Projects, Phorge
avivey added a comment to T15121: Contributor Agreement.

By not signing a CLA, you'd have to explicitly set a license for each contribution you make - i.e., every single revision would have to include an explicit license, or it could not be incorporated into the main code-base.
This is technically handled by item 5 in our license, but it's reasonable to assume nobody ever reads that.

Sat, May 6, 07:24 · Phorge
aklapper closed T15342: PHP 8.1 "strlen(null)" exception blocks rendering a File page when Alt Text was altered, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Sat, May 6, 02:08 · PHP 8 support
aklapper closed T15341: PHP 8.1 "strlen(null)" exceptions block rendering page of a File, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Sat, May 6, 02:07 · PHP 8 support
aklapper closed T15340: PHP 8.1 "strlen(null)" exception blocks Space creation, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Sat, May 6, 02:05 · PHP 8 support
aklapper closed T15339: PHP 8.1 "strlen(null)" exceptions block adding Dashboard to Project Menu, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Sat, May 6, 02:04 · PHP 8 support

Fri, May 5

bfs added a comment to T15121: Contributor Agreement.

I honestly do not want to allow my contributions to be re-licensed, since this usually means that the repository owner wants to re-license that work under a proprietary license when needed. I don't accept that. Normal volunteers do not accept that. This is probably not what we want.

Fri, May 5, 20:27 · Phorge
aklapper closed T15345: PHP 8.1 "strlen(null)" exception blocks editing a Dashboard Tab Panel, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Fri, May 5, 12:54 · PHP 8 support
aklapper closed T15345: PHP 8.1 "strlen(null)" exception blocks editing a Dashboard Tab Panel as Resolved by committing rPa3861edc1946: Fix PHP 8.1 "strlen(null)" exception which blocks editing a Dashboard Tab Panel.
Fri, May 5, 12:54 · PHP 8 support
aklapper closed T15344: PHP 8.1 "strlen(null)" exception when DarkConsole is enabled, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Fri, May 5, 12:51 · PHP 8 support
aklapper closed T15344: PHP 8.1 "strlen(null)" exception when DarkConsole is enabled as Resolved by committing rPf4d28119e849: Fix PHP 8.1 "strlen(null)" exception when DarkConsole is enabled.
Fri, May 5, 12:51 · PHP 8 support
aklapper closed T15348: PHP 8.1 "strlen(null)" exception blocks creating personal and global Herald rules, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Fri, May 5, 10:53 · PHP 8 support

Thu, May 4

aklapper created T15349: Explicitly cover in "Timezone settings" dialog how to ignore the browser vs profile conflict.
Thu, May 4, 20:45 · Good Starter Task
aklapper added a revision to T15345: PHP 8.1 "strlen(null)" exception blocks editing a Dashboard Tab Panel: D25189: Fix PHP 8.1 "strlen(null)" exception which blocks editing a Dashboard Tab Panel.
Thu, May 4, 16:30 · PHP 8 support
aklapper created T15345: PHP 8.1 "strlen(null)" exception blocks editing a Dashboard Tab Panel.
Thu, May 4, 16:29 · PHP 8 support
aklapper added a revision to T15344: PHP 8.1 "strlen(null)" exception when DarkConsole is enabled: D25188: Fix PHP 8.1 "strlen(null)" exception when DarkConsole is enabled.
Thu, May 4, 15:34 · PHP 8 support
aklapper created T15344: PHP 8.1 "strlen(null)" exception when DarkConsole is enabled.
Thu, May 4, 15:33 · PHP 8 support
valerio.bozzolan added a comment to T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog.

Maybe this is the root problem:

Thu, May 4, 09:29 · Arcanist, PHP 8 support
valerio.bozzolan added a comment to T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog.

I just want to note down that this stack trace has no sense to me:

Thu, May 4, 09:15 · Arcanist, PHP 8 support
aklapper closed T15338: PHP 8.1 "preg_match()" exception when pasting malformed Raw Diff into "Create Diff", a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Thu, May 4, 08:56 · PHP 8 support
aklapper closed T15336: PHP 8.1 "strlen(null)" exception blocks rendering a config page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Thu, May 4, 08:48 · PHP 8 support

Wed, May 3

aklapper added a revision to T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog: D25180: Do not pass a null string to mb_convert_case() for PHP 8.1 compatibility.
Wed, May 3, 14:08 · Arcanist, PHP 8 support
aklapper added a revision to T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog: D25179: Fix PHP 8.1 null parameter exceptions which block rendering the "Browse Projects" overlay dialog.
Wed, May 3, 14:02 · Arcanist, PHP 8 support
aklapper created T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog.
Wed, May 3, 13:59 · Arcanist, PHP 8 support
aklapper closed T15325: PHP 8.1 "strlen(null)" exceptions block rendering Auth's Customize Messages page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Wed, May 3, 10:51 · PHP 8 support
aklapper closed T15327: PHP 8.1 "strlen(null)" exception blocks rendering project's Configure Menu page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Wed, May 3, 10:50 · PHP 8 support
aklapper closed T15324: PHP 8.1 "strlen(null)" exception blocks rendering Configuration's Settings page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Wed, May 3, 08:25 · PHP 8 support
aklapper closed T15317: PHP 8.1 "strlen(null)" exception blocks rendering the "Manage Menu" page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Wed, May 3, 08:21 · PHP 8 support

Tue, May 2

valerio.bozzolan added a project to T15315: Fix PHP 8.1 exception from DarkConsole: strlen(): Passing null to parameter #1 ($string) of type string is deprecated: DarkConsole.
Tue, May 2, 11:40 · DarkConsole, PHP 8 support

Mon, May 1

aklapper closed T15297: PHP 8.1 "strlen(null)" exceptions block rendering the People page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 20:31 · PHP 8 support
aklapper closed T15321: PHP 8.1 "strlen(null)" and "array_slice(null)" exceptions block typeahead completion proposals, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 20:29 · PHP 8 support
aklapper closed T15313: PHP 8.1 "strlen(null)" exceptions block rendering a project page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 20:26 · PHP 8 support
aklapper closed T15303: PHP 8.1 "strlen(null)" exception blocks rendering the Projects page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 20:23 · PHP 8 support
aklapper closed T15320: PHP 8.1 "strlen(null)" exception blocks rendering the Notifications' Advanced Search page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 20:18 · PHP 8 support
aklapper closed T15310: PHP 8.1 "strlen(null)" exception blocks rendering External Editor user settings page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 20:14 · PHP 8 support
aklapper closed T15319: PHP 8.1 "strlen(null)" exception blocks rendering user's Edit Profile page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 20:05 · PHP 8 support
aklapper closed T15318: PHP 8.1 "strlen(null)" exceptions block rendering the People page of a user, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 20:03 · PHP 8 support
aklapper closed T15301: PHP 8.1 "strlen(null)" exception blocks loading icons when creating new Diffusion repository, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 20:01 · PHP 8 support
valerio.bozzolan removed a subtask for T15064: Make Phorge compatible with PHP 8.1/8.2: T15198: PHP 8.2 deprecations fix strategies.
Mon, May 1, 15:08 · PHP 8 support
valerio.bozzolan added a project to T15064: Make Phorge compatible with PHP 8.1/8.2: Affects-Wikimedia.
Mon, May 1, 15:02 · PHP 8 support
valerio.bozzolan added a revision to T15315: Fix PHP 8.1 exception from DarkConsole: strlen(): Passing null to parameter #1 ($string) of type string is deprecated: D25165: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole.
Mon, May 1, 14:21 · DarkConsole, PHP 8 support
valerio.bozzolan triaged T15315: Fix PHP 8.1 exception from DarkConsole: strlen(): Passing null to parameter #1 ($string) of type string is deprecated as Normal priority.
Mon, May 1, 14:17 · DarkConsole, PHP 8 support
aklapper closed T15312: PHP 8.1 "strlen(null)" exception blocks rendering list of Active/All projects, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 13:56 · PHP 8 support
aklapper closed T15302: PHP 8.1 "strlen(null)" exceptions block rendering Maniphest task creation page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 13:52 · PHP 8 support
aklapper closed T15296: PHP 8.1 "strlen(null)" exception blocks rendering the Home page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 13:38 · PHP 8 support
aklapper closed T15296: PHP 8.1 "strlen(null)" exception blocks rendering the Home page as Resolved by committing rPf8ae17bb6a1e: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page.
Mon, May 1, 13:38 · PHP 8 support
aklapper closed T15294: PHP 8.1 "strlen(null)" exceptions block rendering the Applications page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 1, 13:34 · PHP 8 support

Sun, Apr 30

aklapper closed T15311: PHP 8.1 "strlen(null)" exception blocks rendering Upload SSH Public key settings dialog, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Sun, Apr 30, 23:08 · PHP 8 support

Apr 30 2023

aklapper closed T15309: PHP 8.1 "strlen(null)" exception blocks rendering creation form pages for Legalpad, Macro, Settings, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Apr 30 2023, 17:42 · PHP 8 support
aklapper closed T15307: PHP 8.1 "strlen(null)" exceptions block rendering the Conduit page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Apr 30 2023, 16:28 · PHP 8 support
aklapper closed T15304: PHP 8.1 "strlen(null)" exceptions block rendering the Conpherence page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Apr 30 2023, 16:25 · PHP 8 support