It slipped me to use arc diff to add this revision, I uploaded a patch file out of first instinct

I tried arc export --diff D25053 --git to merge back in from this Diff in order to arc land, but that's producing a 502 in my case

So I'm currently not sure how to merge and land this -- if anyone who can wants to land it, that's good

I'm also curious if there's a way I can do it, or if my first mistake of not using arc diff has made it more difficult for me

I think the issue is that the patch doesn't cleanly apply after D25050 (which also corrects the slugs on 24/25) --- so it's a git issue rather than an arc one (i.e., git apply <diff> produces an equivalent error). Going through the Update Diff flow in the UI seems to want to create a new revision, rather than update this one. Just abandoning this and starting a new revision might be the easier option.

The arc export thing is weird... that's an Aphront issue looks like:

2022/09/19 22:53:22 [error] 183439#183439: *1021878 FastCGI sent in stderr: "PHP message: [2022-09-19 18:53:22] EXCEPTION: (AphrontParameterQueryException) Expected a numeric scalar or null for %Ld conversion. Query: id IN (%Ld) at [<phorge>/src/infrastructure/storage/xsprintf/qsprintf.php:470]PHP message: arcanist(head=master, ref.master=0c0b9644a6a8), phorge(head=master, ref.master=377ac059d6da)PHP message: [...]

truncated from /var/log/nginx/error.log

Oh, nice!! Lol, when I saw "Update Diviner links" I thought it was something else, then checked the site and found the broken links and created the Diff

I didn't look closely enough to see that it was the Home Page repo, but I did notice something about removing the target="_blank" which was a good idea indeed

I see the changes are deployed now too, along with the the contributing link I couldn't find -- I might be wrong but it doesn't seem possible to find things in Diviner using the global search

(I filed T15119 for the 502 error)