Thanks Andre who fixed all the sub-tasks and deserves all the glory here. I cannot imagine more things to be covered, so, boldly closing.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 1 2025
Thanks. We can update the "We didn't yet release a fix on Phorge" and the "We'll release" since D25967 it's now fixed in master 馃憤
Apr 30 2025
Apr 29 2025
If the CSS rule should not change anything, why does it change something?
Yuuum. As I mentioned downstream ( https://phabricator.wikimedia.org/T380361#10778444 ) I think probably, fortunately, nobody noticed this in a real world, since it's complicated to cause this condition using the API, and probably impossible from the web interface, but this still seems somehow a reasonable workflow and not dead code and the change makes sense. Thaaaanks
Kindly flagging as "little fixes needed on unit tests"
Apr 28 2025
I've added 2 unuseful tips but this seems not ready for production. Flag as "solution seems affected by N+1 query problem". Maybe useful to open a cute task and do more triage.
I've tested in my console:
Relevant report:
Super nice prototype but flagging as "more digging probably needed for production"
Apr 27 2025
Apr 26 2025
Apr 25 2025
Thanks! also for the freshly added unit test :3 :3
Seems fixed now. Thanks :3
Apr 24 2025
Tested on a fresh install!
Seems good to make D25503 more complete, thanks!
Small question: if an user migrates from gmail.com "less secure apps" to gmail.com "App Passwords", isn't that the very same thing?
Good news: we can be even more aggressive about that broken CSS rule, since it seems orphan.
Apr 23 2025
implement documentation tips - thanks - also re-wrap some lines to be under 80 chars
P.S. I wonder... what happens if we expose the width/height here. But probably just touching that would be enough. Still, patch welcome 馃憤
Thanks. Yes. I can reproduce. Relevant documentation:
Thaanks @20after4 - I would say: be bold and mark as resolved to get eternal glory 馃憤 half year of discussion is probably enough and everybody seems happy about this.
Hi @mainframe98 - I still see your block. Do you like the new documentation now? 馃憤
Apr 22 2025
Gents, you鈥檙e both nothing short of geniuses
Oh boy. Thanks
Eventually please try reverting this change in your local copy:
Tip: activate DarkConsole and check requests there 馃憤
Thanks. I also encourage in not following the mentioned implementation, and not only because they have problems with deleted files (interesting) but also because that solution is verticalized on Wikimedia Commons, and nowadays a "modern" embedder system should probably just use the OEmbed protocol that is quite flexible and would support out of the box an incredible amount of websites, potentially including Wikimedia Commons, with relatively few amount of code, than supporting every single website in the universe.
Apr 16 2025
In D25966#25736, @mturdus wrote:
- when using mousedown in combination with an a-tag with href=#, I don't know how to convert e.preventDefault. e.prevent() didn't work the same
Apr 14 2025
Thaanks
Apr 13 2025
Apr 11 2025
Wow, super fast thanks. Maybe nice to expand a bit the src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php
Apr 10 2025
I don't know this detail my friend. Let's wait for other answers.