PHPDoc: Replace invalid "obj" with "object"
Needs ReviewPublic
Actions

Authored by aklapper on Tue, Apr 8, 15:44.

Tags

None

Referenced Files

	F3487127: D25952.1744779026.diff
	Tue, Apr 15, 04:50

	F3422998: D25952.1744639376.diff
	Sun, Apr 13, 14:02

	F3420077: D25952.1744625585.diff
	Sun, Apr 13, 10:13

	F3396307: D25952.1744524312.diff
	Sat, Apr 12, 06:05

	F3395801: D25952.1744517913.diff
	Sat, Apr 12, 04:18

	F3394698: D25952.1744509629.diff
	Sat, Apr 12, 02:00

	F3394652: D25952.1744508204.diff
	Sat, Apr 12, 01:36

	F3394650: D25952.1744508199.diff
	Sat, Apr 12, 01:36

Subscribers

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Summary

Avoid "has invalid return type obj" errors when running static code analysis (PHPStan).
See https://docs.phpdoc.org/guide/references/phpdoc/types.html

Test Plan

Run PHPStan before and after applying this change (and its corresponding Arcanist change), get 15 errors less.

Diff Detail

Repository

rP Phorge

Branch

PhpDocObj (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1849
Build 1849: arc lint + arc unit

Event Timeline

aklapper created this revision.Tue, Apr 8, 15:44

Owners added a reviewer: O1: Blessed Committers.Tue, Apr 8, 15:44

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Apr 8, 15:44

aklapper requested review of this revision.Tue, Apr 8, 15:44

Harbormaster completed remote builds in B1849: Diff 2848.Tue, Apr 8, 15:44

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

infrastructure/

storage/

lisk/

LiskDAO.php

12 lines

59%

O1: Blessed Committers

Diff 2848

View Options

src/infrastructure/storage/lisk/LiskDAO.php

PHPDoc: Replace invalid "obj" with "object"Needs ReviewPublicActions