Page MenuHomePhorge
Differential D25919

Fix invalid CSS cursor value for .phui-oi-grippable
ClosedPublic
Actions

Authored by aklapper on Mar 24 2025, 11:46.
Tags
None
Referenced Files
F3982679: D25919.1746557957.diff
Mon, May 5, 18:59
F3838228: D25919.1746092250.diff
Wed, Apr 30, 09:37
F3828928: D25919.1746066753.diff
Wed, Apr 30, 02:32
F3827610: D25919.1746038424.diff
Tue, Apr 29, 18:40
F3776931: D25919.1745866034.diff
Sun, Apr 27, 18:47
F3775094: D25919.1745858817.diff
Sun, Apr 27, 16:46
F3764426: D25919.1745844112.diff
Sun, Apr 27, 12:41
F3763836: D25919.1745840483.diff
Sun, Apr 27, 11:41
View All 33 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP3acb080f21a2: Fix invalid CSS cursor value for .phui-oi-grippable
Summary

The W3C CSS validator throws Value Error : cursor normal is not a cursor value : normal.
normal is not a valid value for cursor; likely default was meant.
See https://developer.mozilla.org/en-US/docs/Web/CSS/cursor

Test Plan

Paste phui-oi-list-view.css into https://jigsaw.w3.org/css-validator/ and read some CSS docs.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Mar 24 2025, 11:46
Owners added a reviewer: O1: Blessed Committers.Mar 24 2025, 11:46
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMar 24 2025, 11:46

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

aklapper requested review of this revision.Mar 24 2025, 11:46
Harbormaster completed remote builds in B1798: Diff 2767.Mar 24 2025, 11:46
valerio.bozzolan accepted this revision.Wed, Apr 23, 21:02

sgtm

This revision is now accepted and ready to land.Wed, Apr 23, 21:02
aklapper updated this revision to Diff 2903.Thu, Apr 24, 06:04

git rebase master

Harbormaster completed remote builds in B1883: Diff 2903.Thu, Apr 24, 06:04
Closed by commit rP3acb080f21a2: Fix invalid CSS cursor value for .phui-oi-grippable. · Explain WhyThu, Apr 24, 06:05
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP3acb080f21a2: Fix invalid CSS cursor value for .phui-oi-grippable.
aklapper mentioned this in Next Up.Thu, Apr 24, 06:05
avivey mentioned this in 2025.18.Fri, May 2, 11:35

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
phui/
object-item/
2 linesO1: Blessed Committers

Diff 2904

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0