Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery
ClosedPublic
Actions

Authored by aklapper on Mon, Apr 14, 12:18.

Tags

None

Referenced Files

	F3852317: D25964.1746123717.diff
	Wed, Apr 30, 18:21

	F3731430: D25964.1745741084.diff
	Sat, Apr 26, 08:04

	F3708622: D25964.1745641479.diff
	Fri, Apr 25, 04:24

	F3708452: D25964.1745640937.diff
	Fri, Apr 25, 04:15

	F3708307: D25964.1745640502.diff
	Fri, Apr 25, 04:08

	F3708193: D25964.1745640127.diff
	Fri, Apr 25, 04:02

	F3708070: D25964.1745639736.diff
	Fri, Apr 25, 03:55

	F3707889: D25964.1745639196.diff
	Fri, Apr 25, 03:46

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery

Commits

rP7a29a6d15278: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery

Summary

DiffusionCommitQuery passed duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery, making logs slightly more noisy.
Thus run array_unique() before passing.

Closes T16032

Test Plan

Go to http://phorge.localhost/diffusion/commit/query/all/ and look at SQL query in Dark Console before and after applying patch.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Mon, Apr 14, 12:18

Owners added a reviewer: O1: Blessed Committers.Mon, Apr 14, 12:18

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Apr 14, 12:18

aklapper requested review of this revision.Mon, Apr 14, 12:18

Harbormaster completed remote builds in B1870: Diff 2881.Mon, Apr 14, 12:18

Thaanks

This revision is now accepted and ready to land.Mon, Apr 14, 13:21

Closed by commit rP7a29a6d15278: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery. · Explain WhyMon, Apr 14, 20:21

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP7a29a6d15278: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

query/

DiffusionCommitQuery.php

4 lines

O1: Blessed Committers

Diff 2882

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQueryClosedPublicActions