Page MenuHomePhorge

Harbormaster Build Plan: improve input "Depends On"
Open, LowPublic

Description

I noticed that the input field "Depends On" in an Harbormaster Build Plan (/harbormaster/plan/) is not like the traditional ones.

See the specific input in place, and see that it's "not browsable":

Harbormaster Build Plan - Depends On field - highlight meme.jpg (720×978 px, 61 KB)

The current problem is that you cannot browse the values, like it happens in other places, so, you should remember all the desired names, to type them.

Current Implementation

It seems the datasource HarbormasterBuildDependencyDatasource is not browsable, because of some unknown technical debt:

https://we.phorge.it/source/phorge/browse/master/src/applications/harbormaster/typeahead/HarbormasterBuildDependencyDatasource.php;cadc00d744ebcacca7fe56005f963a7b84eb1c4a$6-9

public function isBrowsable() {
  // TODO: This should be browsable, but fixing it is involved.
  return false;
}

https://we.phorge.it/rP7db362a4b652ebaec0258595c8b7d8f0c450f753

It would be nice to understand why the isBrowsable() was set to false, and how to have it true, to complete the HarbormasterBuildDependencyDatasource and make the Harbormaster Build Plan interface more user friendly.