Hide "Audits" section in Email Preferences when uninstalled
Needs ReviewPublic
Actions

Authored by aklapper on Feb 22 2025, 14:33.

Tags

None

Referenced Files

	F3295702: D25894.1742959654.diff
	Tue, Mar 25, 03:27

	F3236166: D25894.1742163608.diff
	Sat, Mar 15, 22:20

	F3225583: D25894.1742135454.diff
	Sat, Mar 15, 14:30

	F3221491: D25894.1741855257.diff
	Wed, Mar 12, 08:40

	F3221320: D25894.1741820970.diff
	Tue, Mar 11, 23:09

	F3188150: D25894.1741362451.diff
	Thu, Mar 6, 15:47

	F3176366: D25894.1741298947.diff
	Wed, Mar 5, 22:09

	F3116263: D25894.1741149000.diff
	Tue, Mar 4, 04:30

Subscribers

Details

Reviewers

mainframe98

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16002: Hide "Audits" section in Email Preferences when Audit is uninstalled

Summary

PhabricatorEmailPreferencesSettingsPanel::getAllEditorsWithTags() queries for all classes extending PhabricatorApplicationTransactionEditor and having getMailTagsMap() to then pull their editor application class. Thus return the correct editor application class.
Followup to rP821708414e.

grep -r "('PhabricatorApplicationTransactionEditor'" . shows only a single result in the Phorge codebase (this PhutilClassMapQuery->setAncestorClass('PhabricatorApplicationTransactionEditor') call) so I assume there will be no unwanted side effects.

Closes T16002

Test Plan