Cannot edit Conpherence rooms on mobile
Open, NormalPublic
Actions

Assigned To

None

Authored By

	Cigaryno
	Jul 1 2023, 15:08

Description

Steps to Reproduce

This bug only occurs on mobile

Go to any Conpherence room.
Tap on the menu icon in the top bar.
Tap Edit Room.

What Happens

An unhandled exception (RuntimeException) will occur.

Screenshot_20241218_093501_Edge.png (2×1 px, 201 KB)

P47 Conpherence update room error

1	Undefined variable: dialog
2	Stack trace:
3	PhutilErrorHandler::handleError called at [/var/www/phorge/src/applications/conpherence/controller/ConpherenceUpdateController.php:209]
4	ConpherenceUpdateController::handleRequest called at [/var/www/phorge/src/aphront/configuration/AphrontApplicationConfiguration.php:284]
5	phlog called at [/var/www/phorge/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
6	PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable called at [/var/www/phorge/src/aphront/configuration/AphrontApplicationConfiguration.php:753]
7	AphrontApplicationConfiguration::handleThrowable called at [/var/www/phorge/src/aphront/configuration/AphrontApplicationConfiguration.php:296]
8	AphrontApplicationConfiguration::processRequest called at [/var/www/phorge/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
9	AphrontApplicationConfiguration::runHTTPRequest called at [/var/www/phorge/webroot/index.php:35]

Possible Cause

The URI for editing Conpherence rooms is something like phorge.example/conpherence/edit/2, but on mobile, it is phorge.example/conpherence/update/2. This could be attributed to line 207 on ConpherenceUpdateController.php

Test Plan

Suggested test plan for your proposed patch:

Go to a Conpherence room in mobile view and select "Edit Room"
Go to a Conpherence room in desktop view and select "Edit Room"
visit a public room as guest (not joined), type a message, press enter: it still works: message sent, and you joined the room.
...