Page MenuHomePhorge

PHPDoc: Replace invalid "key" and "value" types
Needs ReviewPublic

Authored by aklapper on Tue, Apr 8, 15:49.
Tags
None
Referenced Files
F3475905: D25953.1744756738.diff
Mon, Apr 14, 22:38
F3469314: D25953.1744744413.diff
Mon, Apr 14, 19:13
F3426436: D25953.1744650591.diff
Sun, Apr 13, 17:09
F3423769: D25953.1744642724.diff
Sun, Apr 13, 14:58
F3400815: D25953.1744559485.diff
Sat, Apr 12, 15:51
F3395651: D25953.1744517510.diff
Sat, Apr 12, 04:11
F3394369: D25953.1744507019.diff
Sat, Apr 12, 01:16
F3385698: D25953.1744420824.diff
Fri, Apr 11, 01:20

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

Avoid "Parameter has invalid type key" and "Parameter has invalid type value" errors when running static code analysis (PHPStan).
See https://docs.phpdoc.org/guide/references/phpdoc/types.html

Test Plan

Run PHPStan before and after applying this change (and its corresponding Phorge change), get 4 errors less.

Diff Detail

Repository
rARC Arcanist
Branch
PhpDocKeyValue (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1850
Build 1850: arc lint + arc unit