Page MenuHomePhorge

Fix method search result URIs in Diviner
Needs ReviewPublic

Authored by aklapper on Aug 27 2024, 15:46.

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

Going to https://we.phorge.it/diviner/query/all/ and clicking on any of the method results, none of the links work as methods are documented on the page of their corresponding classes while the URI construction code ignores that fact.

Test Plan

Go to /diviner/query/all/, enter random search queries (names of existing methods, substrings of existing methods, a non-existing bogus string, etc) and see that things work better than before (at least for methods).

Diff Detail

Repository
rP Phorge
Branch
divinerMethodURIs
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1572
Build 1572: arc lint + arc unit

Event Timeline

Open question is whether to replace loadAllWhere with loadOneWhere under the assumption that there are always either zero or one results.
That would definitely require adding null check though.