Going to https://we.phorge.it/diviner/query/all/ and clicking on any of the method results, none of the links work as methods are documented on the page of their corresponding classes while the URI construction code ignores that fact.
Closes T16044
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T16044: Diviner: All Method and File query results have invalid 404 URIs
Go to /diviner/query/all/, enter random search queries (names of existing methods, substrings of existing methods, a non-existing bogus string, etc) and see that things work better than before (at least for methods).
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- divinerMethodURIs
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1572 Build 1572: arc lint + arc unit
Event Timeline
Comment Actions
Open question is whether to replace loadAllWhere with loadOneWhere under the assumption that there are always either zero or one results.
That would definitely require adding null check though.
Comment Actions
I've added 2 unuseful tips but this seems not ready for production. Flag as "solution seems affected by N+1 query problem". Maybe useful to open a cute task and do more triage.
| src/applications/diviner/storage/DivinerLiveSymbol.php | ||
|---|---|---|
| 130 | ||
| 134–135 | Maybe just symbolPHID = %s so no need to mpull() | |