Page MenuHomePhorge
Differential D25959

Simplify project regex further
Needs ReviewPublic
Actions

Authored by pppery on Fri, Apr 11, 15:27.
Tags
None
Referenced Files
F3453538: D25959.1744722442.diff
Mon, Apr 14, 13:07
F3441746: D25959.1744693310.diff
Mon, Apr 14, 05:01
F3431181: D25959.1744663928.diff
Sun, Apr 13, 20:52
F3430767: D25959.1744661631.diff
Sun, Apr 13, 20:13
F3408634: D25959.1744596300.diff
Sun, Apr 13, 02:05
F3408401: D25959.1744595431.diff
Sun, Apr 13, 01:50
F3408398: D25959.1744595218.diff
Sun, Apr 13, 01:46
F3407270: D25959.1744590826.diff
Sun, Apr 13, 00:33
View All 19 Files
Subscribers
bekay
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
aklapper
bekay
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T16028: New project remarkup rule misses some project names
Summary

Fixes T16028

Test Plan

Assert that #js-draw-lib (or any other project name with one or two characters followed by a non-word) links correctly. It was previously parsed as #js -draw-lib.

Repeat the test plan for D25838 and observe it still works

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1862
Build 1862: arc lint + arc unit

Revision Contents
Changeset List

PathSizePackages
src/
applications/
project/
remarkup/
7 linesO1: Blessed Committers
__tests__/
15 linesO1: Blessed Committers

Diff 2864

View Options

src/applications/project/remarkup/ProjectRemarkupRule.php

Loading...
View Options

src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0