Page MenuHomePhorge
Differential D25959

Simplify project regex further
Needs ReviewPublic
Actions

Authored by pppery on Fri, Apr 11, 15:27.
Tags
None
Referenced Files
F3686780: D25959.1745585954.diff
Thu, Apr 24, 12:59
F3686390: D25959.1745578373.diff
Thu, Apr 24, 10:52
F3686286: D25959.1745575371.diff
Thu, Apr 24, 10:02
F3665301: D25959.1745464741.diff
Wed, Apr 23, 03:19
F3645308: D25959.1745368980.diff
Tue, Apr 22, 00:43
F3605442: D25959.1745269647.diff
Sun, Apr 20, 21:07
F3605432: D25959.1745268437.diff
Sun, Apr 20, 20:47
F3577443: D25959.1745083545.diff
Fri, Apr 18, 17:25
View All 37 Files
Subscribers
bekay
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
aklapper
bekay
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T16028: New project remarkup rule misses some project names
Summary

Fixes T16028

Test Plan

Assert that #js-draw-lib (or any other project name with one or two characters followed by a non-word) links correctly. It was previously parsed as #js -draw-lib.

Repeat the test plan for D25838 and observe it still works

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1862
Build 1862: arc lint + arc unit

Revision Contents
Changeset List

PathSizePackages
src/
applications/
project/
remarkup/
7 linesO1: Blessed Committers
__tests__/
15 linesO1: Blessed Committers

Diff 2864

View Options

src/applications/project/remarkup/ProjectRemarkupRule.php

Loading...
View Options

src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0