Remove orphan CSS rules from phui-timeline-view.css
ClosedPublic
Actions

Authored by aklapper on Mar 24 2025, 11:38.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP367de18e7902: Remove orphan CSS rules from phui-timeline-view.css

Summary

.phui-timeline-preview-header has never been used since introduction in rPdb66cd830d1b.
Only use of .phui-timeline-change-details was removed in direct followup rP4e8e035de006.

Test Plan

Grep the code.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Mar 24 2025, 11:38

Owners added a reviewer: O1: Blessed Committers.Mar 24 2025, 11:38

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

aklapper requested review of this revision.Mar 24 2025, 11:38

Harbormaster completed remote builds in B1797: Diff 2766.Mar 24 2025, 11:38

Good news: we can be even more aggressive about that broken CSS rule, since it seems orphan.

Nothing in the source code seems to call it:

$ grep -R 'phui-timeline-preview' src/ resources/ support/ webroot/
webroot/rsrc/css/phui/phui-timeline-view.css:.phui-timeline-preview-header {

And only one commit introduces a line about it, and it's only the CSS definition:

$ git log -G 'phui-timeline-preview'
commit db66cd830d1be431424d9ce147381e02a08c5727

So, introduced only here, orphan since it's creation in 2014:

rPdb66cd830d1b: PHUITimelineView

→ LET'S DROP phui-timeline-preview-header

bwahaha

Anyway the proposed change seems like reviving a dead horse, since the supposed syntax should be:

border: {width} {style} {color};

But the syntax A/B is (still) this:

border: {style} {color} {width};

Anyway I assume that the original intention was set top+bottom = 1px, and left+right = 0 but it cannot work like that. Anyway, who cares, we will never know. Let's drop that.

This revision now requires changes to proceed.Thu, Apr 24, 09:16

git rebase master only; still Needs Revision

Harbormaster completed remote builds in B1884: Diff 2908.Thu, Apr 24, 15:09

Remove two orphan CSS rules from phui-timeline-view.css

Harbormaster completed remote builds in B1885: Diff 2909.Thu, Apr 24, 15:25

aklapper retitled this revision from Fix invalid CSS border value for .phui-timeline-preview-header to Remove orphan CSS rules from phui-timeline-view.css.Thu, Apr 24, 15:26

aklapper edited the summary of this revision. (Show Details)

aklapper edited the test plan for this revision. (Show Details)

sgtm