Page MenuHomePhorge

Regression: Sending a message in Conpherence rooms opens dialog to edit room
Closed, ResolvedPublic

Description

When I try to take actions in Conpherence rooms, such as sending a message, the action does not complete and a dialog to edit the room appears instead. This also seems to intermittently appear on other unrelated pages elsewhere within Phorge.

I've been able to reproduce this in a screen recording and @jmas4 has done so himself in Q175. To do so yourself, perform the following steps:

  1. Navigate to a room (for instance, Z1)
  2. Type a message and press to send it

I would expect the message to send and to appear in the list of messages within the room. Instead, a dialog to edit the room appears.


For my own reference whilst working on this bug, I'm tracking it locally in T106.

Event Timeline

From checking the network requests when I load an unrelated page and the dialog appears, I can see a POST request to /conpherence/edit/1/ which returns the dialog. I've attached both the request and the response, with light redactions, to P48 and P49.

The initiating callsite for the HTTP request is core.pkg.js:1346 which resolves back to utility code to make HTTP requests in rP at webroot/rsrc/externals/javelin/lib/Request.js:172. I need to identify the actual call-site and go from there.

connorgurney renamed this task from Fix bug with inability to take actions in Conpherence rooms as modal to edit room appears instead to Fix bug with inability to take actions in Conpherence rooms as dialog to edit room appears instead.Apr 22 2025, 01:31
connorgurney updated the task description. (Show Details)

Eventually please try reverting this change in your local copy:

https://we.phorge.it/rPfd6118bfa601c1f48923cbe3f5d6bab61d5b36ab

To go in the previous commit, you can do that with:

git reset --hard 5b8713889487c3f6fa8ee04333f7d551349cf859

To restore latest change, just:

git pull

I can reproduce, looks like the change in src/applications/conpherence/controller/ConpherenceViewController.php is the culprit.
No clue what's a correct fix, thus proposing to revert the entire commit.

aklapper renamed this task from Fix bug with inability to take actions in Conpherence rooms as dialog to edit room appears instead to Regression: Sending a message in Conpherence rooms opens dialog to edit room.Apr 22 2025, 12:55

Gents, you’re both nothing short of geniuses—fixed before I’d even blinked! Thanks. Will look at fixing it permanently in T15513.

Gents, you’re both nothing short of geniuses

I have few seconds before being killed for revealing this... stay ready... 3... 2.... management encourages us to break things to attract code contributors, that is why we are so fast in fixing: we are the caus *SHOOOOT* *BLASTED* *SPLAT*

This project is now abandonware without you. 😆