Differential D25868
Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header Authored by aklapper on Feb 10 2025, 19:30. Tags None Referenced Files
Details
Passing null to preg_match() is deprecated behavior since PHP 8.1. ERROR 8192: preg_match(): preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated #0 preg_match(string, NULL) called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:629] Closes T15829 Access a task page etc in a browser which does not set a User-Agent HTTP Header string.
Diff Detail
Event TimelineComment Actions I found this, which suggests that this shouldn't be used for headers. https://secure.phabricator.com/D21862 Comment Actions According to the documentation, AphrontRequest::getHTTPHeader will only wild if its second argument (null here) is given. Even then, only if you put something that phutil_nonempty_string doesn't like as the second argument is that an issue. |