Thanks my friend
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 19 2023
You are a good minion, thanks bob
I will kindly resign since I'm terrible at frontend :) Others: please help here
For faster review I would like to try to explain better to others why it was necessary to change so many selectors to change the Workboards scrollbar, but I'm not 100% sure about .phui-flank-view-body and the shadow thing.
Can somebody else test this? I need more time, since I have issues with hosted repositories at the moment :(
Thanks! Tested locally. This seems separated from the mentioned regression. Indeed the recurrence ID and the instance ISO seems that must be strings, or NULL, and any other value will cause a violent nuclear implosion as usual, and Phorge somehow likes it.
Interesting. ICS URI import was fixed in 02a4f8b0c8f1279fc but at the cost of breaking ICS file import.
Tested both cases, thanks
Aug 18 2023
Yeah anyway this looks great
SUPER NICE \o/ THANKS
Tested with and without D25387.
This happened some minutes ago to our friend @waldyrious and I was able to reproduce it on my local computer. I've attached my reproducing instructions.
Maybe to be it consistent with "super-rebranded-product/" :D I don't know
Yeah fixed in D25104
I've just:
git rebase master
Let's visually mark this as needing still some work
Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:
I've tested this in place with my eyes on a friend's laptop with PHP 8.1 in the very same problem
Nice job, my little and cute bob.. OH NO! a super-important regression! all of you minions will be fired soon!1!
OK I've found that this is about the legacy Conduit entry point for Paste.
I'm not able to trigger that part of the code.
Tested with and without a value, thaaanks \o/
Aug 17 2023
Tested, nice thaaaanks, with and without dark mode.
Also this is an excuse to run arc diff again, since tests and lints were skippeds :^)
I just mean that if($something) is usually avoided in Phorge "only and mainly" because if("0") is counter-intuitively false (so "0" is falsy even if it's a non-empty string). But here, we have not that problem, since "0" is a don't care value.
Thaanks bob
For some reasons I'm not able to trigger this problem, but that seems perfect to me, thaaaaanks
Yeah feel free to land this as-is, that was easy-peasy accepted
Nice thaaanks
Yeah thanks
Thanks for this change! Just a small thing
Aug 16 2023
I tested this without finding any nuclear implosion. Thanks!
Aug 15 2023
arc lint
arc unit
Please wait more feedback from avivey, but I wanted to say that I tested this and I love it
Yeah why not. asd
Thanks for this change that looks absolutely reasonable.
This seems totally backward compatible to me
Thanks for this. I need a double-check since I'm quite scared by the background of this root problem but fortunately this seems to have just one occurrence, the one you are fixing.
I love this change, I've looked inside the logic and it seems very correct to me,
Yeah bob this change was already accepted, and now it's super-accepted. This change is adorable, thanks!
Aug 11 2023
Please also manually run this
Yeah bob, feel free to add your nice screenshots in the Task description for more visibility. You are a good minion!
Thanks! Interestingly you fixed an incomplete fix since D25128