Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in Conduit
ClosedPublic

Authored by aklapper on Aug 17 2023, 15:43.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 15, 11:30
Unknown Object (File)
Sat, Jun 15, 11:29
Unknown Object (File)
Sat, Jun 15, 10:38
Unknown Object (File)
Sat, Jun 15, 09:57
Unknown Object (File)
Tue, Jun 11, 10:24
Unknown Object (File)
Sun, Jun 9, 16:38
Unknown Object (File)
Sun, Jun 9, 14:21
Unknown Object (File)
Thu, Jun 6, 22:20

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=df6c315ace5f), phorge(head=master, ref.master=7cffe557ac24)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php:28]

Closes T15614

Test Plan

Create a Phriction document without slug via Conduit. Get an EXCEPTION: (Exception) No such document. instead of a strlen() exception.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable