Probably no need for a warning. Info is OK. Thanks

Since using E_STRICT is deprecated, I thought the simple fact of using it from whatever Arcanist CLI (e.g. arc anoid) was triggering this new warning (with or without having an exception - since that line 18 is supposed to be always executed I think)

What do you think about @mturdus?

You know better than me the context. Is there a possibility that an installation is already without that column?

OK lol no, this has nothing to do with D25898. Need another task for the "Missing input descriptions"

In D25898#24165, @avivey wrote:

• There's already a "description" field on these, which I think was supposed to be displayed; We might have lost it at some point, which is concerning.

have an approved Revision", but this too can be tricked by a sufficiently competent user

Hackerman meme

clarify how to run the command (last change promise)

Aldo I may need extra help from @waldyrious asdlol (on the Documentation I mean)

aaand I go to bed :3

OK my friend, I've worked a lot to make it shorter... but still more dense of useful info, reducing jokes at minimum.

Dear friend @mainframe98 - I suggest to click the button Hide "Done" inlines in the top-right corner to easily do another reading

You mean a shorthand for git revert + arc diff? Sounds reasonable

Potentially related to Herald. Adding Herald to raise more attention.

Tried. I Shall Not Pass :O

@avivey what do you think about? Maybe we can test with some powerful clicks

I confirm that ./bin/celerity map does nothing after this change

This makes me and probably other people mad lol

Aaand last 48 lines checked. Differential is crashing in my laptop lol

(Review 3 of ?)

P.S. maybe nice to introduce in AphrontView a method like getUserRequired() or something similar to implement exactly this logic - so we avoid that scattered logic everywhere

(epic review part 1 of ?)

and reviews love you too! (lol)

In D25872#23861, @nib wrote:

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

public function buildBranchName($task_ref) {
  $task_name = $task_ref->getName();
  // regex, preg_replace, trim, etc
  return $branch_name;
}

I don't know if anybody is supposed to run

Small question. Is it supposed to be used with null+null?

Another option is just declaring $path = '' as default in 209 maybe

I've tested this and I'm impressed. You probably have changed my life.

Gotcha. Any opinion on this?

Maybe duplicate patch, look for same title (I'm on mobile now)

Finally something that can be tested using arc anoid - I guess?

Test plan works! Thanks :3

Hi @nib - still thanks and you are welcome in updating this patch using something like this:

last cosmetic change on a title with extra "==="

Question: in an ideal world would you love even more the same button, that "just" prefills the textarea? That could be also probably done server-side, without JavaScript. That would help T15991 even more I think.

add missing comma

implement tips, simplify (thanks)

With full respect of Badges, I don't see how a business can build an empire on this Badges menu entry. Anyway, if your business feel tampered by having this moved down by some pixels, please propose a patch to introduce a better menu management for this, like project menu that is more flexible :3

Insert a tear to play again :3

You're fast. lol I approve because life is too short.

(Maybe also moving in line 316, before phutil_utf8_strtolower() and the regexes)

With this I have a regression in /w/. Do you have too?

Thanks Cigaryno. I think it's good to start a discussion on this and I appreciate you started this. I also have seen github.com suggested somewhere.

Thanks. I'm curious if there's anything up that should not call this with null. Also I'm curious to test with a couple of date filters and custom date fields.

Thanks! I'm sorry that the execute method has undocumented return.

Thanks! I share a comment on the fly, maybe more comments soon after a test :)

OK super! <3

Thaanks!

(1. Are you an heroic package manager? <3 nice to know!)

I see the PHP approach is interestingly in line with stuff like line 11. wow lol. Thanks

Whopsie whopsie... you are now in the family of trusted contributors \o/

Do you think that this is wontfix? I think yes after https://we.phorge.it/T15281#10042

P.S. - finally a Mercurial user! Please try D25823 in Mercurial :D if it works for you, feel free to accept, or share any feedback

(Don't worry, I'm also super confused by arc now. lol - it still does not apply cleanly to me, so I've downloaded the patch...)

Maybe we need to rebase on top of 7955fe6df701 (I don't have the base af404703cbe9 locally)

Thaaanks taavi! Known non-issue: somebody may wonder why in Maniphest the "Queries" are listed before other things. I may answer that in Phame the "Queries" are listed after other things. So this is consistent with Phame /phame/post/ page. lol

If you want to easily try that missing piece I can add it with a little cute amend (keeping your authorship). We can always rollback the patch if you don't like the result or if it creates a nuclear weapon. Sounds OK?

OK probably just this is missing

It works on my computer but I see that in the left sidebar usually there is "Queries" 🤔 instead it seems to work for ManiphestController and similar ones

Welcome PHP 8.4

(Additional context: as follow-up request, the most adopted token MUST always be "fox" or "🦊", forever - even if not available. So maybe the implementation is a bit simpler and efficient 👍 lol)