Page MenuHomePhorge

People Profile Menu: Move "Badges" item lower in panel list
ClosedPublic

Authored by aklapper on Fri, Feb 14, 13:43.
Tags
None
Referenced Files
F2989016: D25876.1740165186.diff
Thu, Feb 20, 19:13
F2982818: D25876.1739971923.diff
Tue, Feb 18, 13:32
F2982746: D25876.1739971750.diff
Tue, Feb 18, 13:29
F2982643: D25876.1739965390.diff
Tue, Feb 18, 11:43
F2978972: D25876.1739737347.diff
Sat, Feb 15, 20:22
F2978946: D25876.1739730969.diff
Sat, Feb 15, 18:36
F2978942: D25876.1739728837.diff
Sat, Feb 15, 18:00
F2978908: D25876.1739721147.diff
Sat, Feb 15, 15:52

Details

Summary

The order of items in the main panel on a user profile page is currently (depending on which Phorge applications are installed): Profile, Badges, Tasks, Revisions, Commits, Manage.
This order does not reflect the common main interests of most users in my installation who try to find and do work, I'm afraid.
Thus change it to Profile, Tasks, Revisions, Commits, Badges, Manage.

Test Plan

Go to http://phorge.localhost/people/manage/1/ and look at the panel on the left. See that Badges is not listed second anymore but is listed last but one.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php
6–12

Should the const lines 6-12 be re-ordered to put Badges on the bottom? Or it does nothing?

src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php
6–12

Why? The list wasn't ordered before either?

src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php
6–12

I just wanted to know if sorting these lines has any impact or not, but now I came to the conclusion that it does nothing.

With full respect of Badges, I don't see how a business can build an empire on this Badges menu entry. Anyway, if your business feel tampered by having this moved down by some pixels, please propose a patch to introduce a better menu management for this, like project menu that is more flexible :3

This revision is now accepted and ready to land.Mon, Feb 17, 07:28