Remove use of deprecated E_STRICT PHP constant
Needs ReviewPublic
Actions

Authored by aklapper on Mon, Feb 17, 11:37.

Tags

None

Referenced Files

	F2988967: D25886.1740158458.diff
	Thu, Feb 20, 17:20

	F2988360: D25886.1740147878.diff
	Thu, Feb 20, 14:24

	F2988344: D25886.1740146324.diff
	Thu, Feb 20, 13:58

	F2982831: D25886.1739971953.diff
	Tue, Feb 18, 13:32

	F2982767: D25886.1739971798.diff
	Tue, Feb 18, 13:29

	F2980630: D25886.1739901372.diff
	Mon, Feb 17, 17:56

	F2980524: D25886.1739897626.diff
	Mon, Feb 17, 16:53

	F2980435: D25886.1739891140.diff
	Mon, Feb 17, 15:05

Subscribers

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

Summary

The E_STRICT PHP constant is deprecated since PHP 8.4 per https://www.php.net/manual/en/migration84.deprecated.php.
Per https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant, the E_STRICT constant was still in use in-between PHP 7.0 and 7.4 for PHP's mysqli extension and PHP's htmlentities() function. Since rP23a49eb403c9ea6c58f4ae2f22416e90a9d24c14, Phorge requires 7.2.25. Phorge neither uses PHP's mysqli extension nor calls PHP's htmlentities() function.
Thus remove its usage, as E_STRICT is a part of E_ALL since PHP 5.4.0 per https://github.com/php/php-src/blob/php-5.4.0/NEWS#L69.