Page MenuHomePhorge

User config change: add more useful title in feed (PhabricatorUserPreferencesTransaction)
Open, WishlistPublic

Description

This is a minimal feature incomplete.

Steps to reproduce:

  • change a personal setting and save (like, Date and TimeWeek Starts On)

What happens:

If you visit the /feed/transactions/ page, then you see this:

foo edited this object (transaction type "setting")

This means that this class has no title:

https://we.phorge.it/source/phorge/browse/master/src/applications/settings/storage/PhabricatorUserPreferencesTransaction.php

What should happen instead:

At least something minimal like:

foo updated their personal settings

And maybe in the future something even more useful.

Minimal viable product:

public function getTitle() {
    return pht(
      '%s updated the personal settings.',
      $this->renderAuthor());
}

In the future we can then maybe show something even more useful for extra auditing glory.