Convert tokens given to use SearchEngine
Needs ReviewPublic
Actions

Authored by taavi on Tue, Feb 4, 13:11.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15988: Allow filtering tokens given by list of token

Summary

refs T15988

Test Plan

Tested that /token/ still renders fine.

Order by Creation (Newest First): it works.

Order by Creation (Oldest First): it works.

Diff Detail

Repository

rP Phorge

Branch

tokens-search

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1680
Build 1680: arc lint + arc unit

Event Timeline

taavi created this revision.Tue, Feb 4, 13:11

Owners added a reviewer: O1: Blessed Committers.Tue, Feb 4, 13:11

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Feb 4, 13:11

taavi requested review of this revision.Tue, Feb 4, 13:11

Harbormaster completed remote builds in B1680: Diff 2616.Tue, Feb 4, 13:11

valerio.bozzolan edited the test plan for this revision. (Show Details)Tue, Feb 4, 13:51

It works on my computer but I see that in the left sidebar usually there is "Queries" 🤔 instead it seems to work for ManiphestController and similar ones

OK probably just this is missing

diff --git a/src/applications/tokens/controller/PhabricatorTokenController.php b/src/applications/tokens/controller/PhabricatorTokenController.php
index 8cd61b92b6..c1ff7408aa 100644
--- a/src/applications/tokens/controller/PhabricatorTokenController.php
+++ b/src/applications/tokens/controller/PhabricatorTokenController.php
@@ -3,9 +3,15 @@
 abstract class PhabricatorTokenController extends PhabricatorController {
 
   protected function buildSideNav() {
+    $viewer = $this->getViewer();
+
     $nav = new AphrontSideNavFilterView();
     $nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
 
+    id(new PhabricatorTokenGivenSearchEngine())
+      ->setViewer($viewer)
+      ->addNavigationItems($nav->getMenu());
+
     $nav->addLabel(pht('Tokens'));
     $nav->addFilter('given/', pht('Tokens Given'));
     $nav->addFilter('leaders/', pht('Leader Board'));

If you want to easily try that missing piece I can add it with a little cute amend (keeping your authorship). We can always rollback the patch if you don't like the result or if it creates a nuclear weapon. Sounds OK?