Paths

Table of Contentst

Differential D25890

Fix PHP 8.1 "ltrim(null)" exception creating a Nuance Source
ClosedPublic
Actions

Authored by aklapper on Tue, Feb 18, 23:29.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16000: PHP 8.1 "ltrim(null)" exception creating a Nuance source

Commits

rP5b8713889487: Fix PHP 8.1 "ltrim(null)" exception creating a Nuance Source

Summary

Passing null as the first parameter to ltrim() is deprecated since PHP 8.1.
Thus change the optional parameter of the function from null to an empty string.

ERROR 8192: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/src/applications/nuance/source/NuanceSourceDefinition.php:211]

Closes T16000

Test Plan

Create a Nuance queue at /nuance/queue/edit/form/default/
Create a Nuance "Web Form" type source at /nuance/source/edit/form/default/

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Tue, Feb 18, 23:29

Owners added a reviewer: O1: Blessed Committers.Tue, Feb 18, 23:29

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Feb 18, 23:29

aklapper requested review of this revision.Tue, Feb 18, 23:29

Harbormaster completed remote builds in B1730: Diff 2678.Tue, Feb 18, 23:29

Another option is just declaring $path = '' as default in 209 maybe

This revision is now accepted and ready to land.Wed, Feb 19, 08:11

Do the easier and more obvious thing that Valerio proposed

Harbormaster completed remote builds in B1737: Diff 2685.Thu, Feb 20, 18:07

aklapper edited the summary of this revision. (Show Details)Thu, Feb 20, 18:09

Closed by commit rP5b8713889487: Fix PHP 8.1 "ltrim(null)" exception creating a Nuance Source. · Explain WhyThu, Feb 20, 18:10

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP5b8713889487: Fix PHP 8.1 "ltrim(null)" exception creating a Nuance Source.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

nuance/

source/

NuanceSourceDefinition.php

2 lines

O1: Blessed Committers

Diff 2686

src/applications/nuance/source/NuanceSourceDefinition.php

Loading...