Details
- Reviewers
avivey - Group Reviewers
O1: Blessed Committers - Commits
- rPa474a38dd689: Update installation guide to point to GitHub mirrors
Run the git clone commands.
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Thanks Cigaryno. I think it's good to start a discussion on this and I appreciate you started this. I also have seen github.com suggested somewhere.
Thought, having the GitHub link in my opinion:
- is probably not good to promote Phorge lol
- it adds extra entropy to some contributors since "arc diff" may introduce silly things if the user started pulling from GitHub instead of this upstream
- I personally dislike GitHub, just like I dislike having my foot on a shit lol - but this may be not relevant
So, if bandwidth is a reduced resource for Phorge resources, I'm ready to donate to Phorge to increase this resource, so that we can avoid to promote GitHub 👍
I mean, I understand that this is "a very minor promotion" and I understand that Phorge.it is different from the Phorge software, but I think that "avoiding GitHub" / "saving people from GitHub" is probably a good long-term direction.
I'm a bit worried that people will create Pull Requests on Github after downloading from Github...
Apart from download speed, are there other reasons why to recommend an external service?
I don't know (I do know typing phorge on a search engine will show the GH mirror), but the old Phabricator README had an NO PULL REQUESTS section with a link to the Phab contributor guide, in an effort to reduce if not eliminate pull requests. There was also a SUPPORT RESOURCES section for users willing to request features or report bugs or security issues. Maybe we can have the same thing on the Phorge README?
Also, do you think everyone can understand that Read-only mirror! means No pull requests!?
No, because people do not read. The "read-only mirror" Wikimedia and GNOME code repos on GitHub regularly receive pull requests because people do not read anything.
I'd like people to clone from GH less for the bandwidth and more for the availability - GH is more likely to be up then us.
Technically I guess GH might have an issue with that, but they probably won't notice anyway.
arc diff should work just fine even if you cloned from GH - the .arcconfig file takes care of that.
And at this point, I suspect that even if we delete the github mirror, people will find a way to open GH PRs for us. There's still one or two every year for Phabricator...