-minline-all-stringops is a x86 only option, and will not work on other architectures.
Thus remove it for other architectures.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rARCb52ea9932a11: xhpast: Skip -minline-all-stringops on non-x86 architectures
Build on other architectures. I cherry-picked this to AOSC OS packaging and it has built successfully on amd64, arm64, riscv64, ppc64el, loongson3, loongarch64.
Or, manually run this script and see that - only on x86 - it prints the mentioned flag:
php support/xhpast/bin/xhpast-generate-release-cppflags.php
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html
I see the PHP approach is interestingly in line with stuff like line 11. wow lol. Thanks
| support/xhpast/bin/xhpast-generate-release-cppflags.php | ||
|---|---|---|
| 5–6 | Very probably there is no need for these 2 lines in this script. Maybe better to comment to reduce loaded resources. | |
| support/xhpast/bin/xhpast-generate-release-cppflags.php | ||
|---|---|---|
| 12 | Ops wait. Please don't sum in PHP. Use the concatenate operator with dot. Otherwise in recent PHP versions this can throw an error | |
