Page MenuHomePhorge

Fix overlapping elements in Phame for >1791px width
ClosedPublic

Authored by aklapper on Feb 13 2025, 17:31.

Details

Summary
Test Plan

For both a viewport width >1791px and below,

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

With this I have a regression in /w/. Do you have too?

aklapper edited the test plan for this revision. (Show Details)

Fix unaligned elements by changing margin-left: -200px to -300px for div.phui-document-content and for full-size images, and by bumping max-width: 980px; to now 1280px for .phame-home-view .phame-home-container to avoid element overlapping

I expanded the test plan a bit, still if there is more to add please also expand. This seems to work for me (phamous last words)

sorry for the late reply.
This looks good to me.

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

This revision is now accepted and ready to land.Fri, Apr 11, 07:55