Nice catch, thanks! Sorry for this regression in unit tests

I confirm with my hand on my heart that I've consumed my eyes inspecting every single line to be absolutely sure that this PHPDoc probably has a better meaning and will not cause nuclear implosions.

OK thanks (I need some rest)

Maybe better to discuss a little bit in T15848: newOAuth1Future doesn't set a User-Agent since I'm curious but also confused

I would like to better understand the root problem. I see that Cloudflare was showing a captcha to Phorge (what Phorge?). It seems it was because an user agent was missing. But aklapper said that we are already setting an user agent.

I just discovered that sometime we can spawn warnings above the comment box.

(In general thanks and please do whatever needed change in PHPDoc but let's reduce the commits on single files for different PHPDoc changes; so if you have lot of warnings on a single file, just do them all thanksl

This sounds like something that folks at Facebook were overriding / patching. But, the class is final so it's difficult to believe that really somebody is using this.

fix typos in documentation

add a bit of documentation - just because we can

Thanks. Premising that $body can be null and that's a feature

In D25731#21672, @aklapper wrote:

I don't favor implementing non-obvious behavior ("why does it sometimes do this but not always"). :)

An additional check to make milestone owners happy might be: look to see if the board shows at least one task. If not, proceed.

Since you helped a lot in D25774 - I'm not sure this is needed anymore. Maybe better to get better opinions. For example I found this a bit irritating for my archived Milestones.

Thanks aklapper. Seems good from our side @speck?

Agree. But the best I can do is... adding a slider that, the more you scroll it, the more it hides the red text/green text... LOL

Untested but seems good to me, maybe nice to add a couple of

git rebase master

Good question. The documentation is not "super-opinionated" about this - https://we.phorge.it/book/contrib/article/unit_tests/

P.S. try applying D25809 to check if the red unit test becomes green

Thanks again. Let's see if we receive some feedback from users in master branch

Thanks. Premising that I also don't like projects with "automagic getters" so I agree with you; here how every getter works in Phabricator/Phorge:

FYI T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal

I personally prefer option 1, so, removing the duplicate body. So there is more creative space to then add a more useful body in the future.

This is becoming quite frustrating in my workplace in Torino. Let's start immersion mode.