Page MenuHomePhorge
Differential D25782

Remove unused PhutilConsoleProgressSink::getWidth()
ClosedPublic
Actions

Authored by aklapper on Aug 16 2024, 06:34.
Tags
None
Referenced Files
F3604351: D25782.1745183706.diff
Sat, Apr 19, 21:15
F3554270: D25782.1744982882.diff
Thu, Apr 17, 13:28
F3398948: D25782.1744543446.diff
Sat, Apr 12, 11:24
F3389677: D25782.1744460054.diff
Fri, Apr 11, 12:14
F3387596: D25782.1744439283.diff
Fri, Apr 11, 06:28
F3372016: D25782.1744247547.diff
Wed, Apr 9, 01:12
F3371497: D25782.1744242398.diff
Tue, Apr 8, 23:46
F3368894: D25782.1744212067.diff
Tue, Apr 8, 15:21
View All 43 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth()
Summary

This private function was added in https://secure.phabricator.com/rPHU71e8d7a4cf8e9f56b1427c27b3684ae17a3ea7c7 and has never been used.

Test Plan

Grep the code; run static code analysis.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 16 2024, 06:34
Owners added a reviewer: O1: Blessed Committers.Aug 16 2024, 06:34
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2024, 06:34
aklapper requested review of this revision.Aug 16 2024, 06:34
Harbormaster completed remote builds in B1532: Diff 2377.Aug 16 2024, 06:34
valerio.bozzolan accepted this revision.Sep 4 2024, 09:37
valerio.bozzolan added inline comments.
src/progress/PhutilConsoleProgressSink.php
27

I think the mentioned method was probably part of this TODO,
to draw a progress bar with the size of the screen.

So maybe it's OK to drop until completed.

This revision is now accepted and ready to land.Sep 4 2024, 09:37
Closed by commit rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth(). · Explain WhySep 4 2024, 09:46
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth().

Revision Contents
Changeset List

PathSizePackages
src/
progress/
11 linesO1: Blessed Committers

Diff 2444

View Options

src/progress/PhutilConsoleProgressSink.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0