Page MenuHomePhorge
Differential D25782

Remove unused PhutilConsoleProgressSink::getWidth()
ClosedPublic
Actions

Authored by aklapper on Aug 16 2024, 06:34.
Tags
None
Referenced Files
F3323334: D25782.1743385265.diff
Sun, Mar 30, 01:41
F3317983: D25782.1743270709.diff
Fri, Mar 28, 17:51
F3307768: D25782.1743151733.diff
Thu, Mar 27, 08:48
F3306800: D25782.1743132524.diff
Thu, Mar 27, 03:28
F3305626: D25782.1743117910.diff
Wed, Mar 26, 23:25
F3303848: D25782.1743087437.diff
Wed, Mar 26, 14:57
F3290724: D25782.1742871282.diff
Mon, Mar 24, 02:54
F3285277: D25782.1742797432.diff
Sun, Mar 23, 06:23
View All 30 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth()
Summary

This private function was added in https://secure.phabricator.com/rPHU71e8d7a4cf8e9f56b1427c27b3684ae17a3ea7c7 and has never been used.

Test Plan

Grep the code; run static code analysis.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 16 2024, 06:34
Owners added a reviewer: O1: Blessed Committers.Aug 16 2024, 06:34
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2024, 06:34
aklapper requested review of this revision.Aug 16 2024, 06:34
Harbormaster completed remote builds in B1532: Diff 2377.Aug 16 2024, 06:34
valerio.bozzolan accepted this revision.Sep 4 2024, 09:37
valerio.bozzolan added inline comments.
src/progress/PhutilConsoleProgressSink.php
27

I think the mentioned method was probably part of this TODO,
to draw a progress bar with the size of the screen.

So maybe it's OK to drop until completed.

This revision is now accepted and ready to land.Sep 4 2024, 09:37
Closed by commit rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth(). · Explain WhySep 4 2024, 09:46
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth().

Revision Contents
Changeset List

PathSizePackages
src/
progress/
11 linesO1: Blessed Committers

Diff 2444

View Options

src/progress/PhutilConsoleProgressSink.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0