Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text
ClosedPublic

Authored by aklapper on Sep 4 2024, 08:13.
Tags
None
Referenced Files
F3341910: D25817.1743658936.diff
Wed, Apr 2, 05:42
F3338254: D25817.1743601729.diff
Tue, Apr 1, 13:48
F3334660: D25817.1743552484.diff
Tue, Apr 1, 00:08
F3334102: D25817.1743545041.diff
Mon, Mar 31, 22:04
F3331933: D25817.1743515720.diff
Mon, Mar 31, 13:55
F3329908: D25817.1743481225.diff
Mon, Mar 31, 04:20
F3326559: D25817.1743420967.diff
Sun, Mar 30, 11:36
F3319063: D25817.1743298837.diff
Sat, Mar 29, 01:40

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Refs T15936

Test Plan

Read the code; compare to D25186.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable