Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text
ClosedPublic

Authored by aklapper on Sep 4 2024, 08:13.
Tags
None
Referenced Files
F2916563: D25817.1737494796.diff
Mon, Jan 20, 21:26
F2874980: D25817.1736968264.diff
Tue, Jan 14, 19:11
F2874979: D25817.1736968263.diff
Tue, Jan 14, 19:11
F2874842: D25817.1736964693.diff
Tue, Jan 14, 18:11
F2874774: D25817.1736962367.diff
Tue, Jan 14, 17:32
F2874283: D25817.1736945207.diff
Tue, Jan 14, 12:46
F2872981: D25817.1736906882.diff
Tue, Jan 14, 02:08
F2872370: D25817.1736891249.diff
Mon, Jan 13, 21:47

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Refs T15936

Test Plan

Read the code; compare to D25186.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable