Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text
ClosedPublic

Authored by aklapper on Sep 4 2024, 08:13.
Tags
None
Referenced Files
F3004298: D25817.1740485126.diff
Mon, Feb 24, 12:05
F3004293: D25817.1740484917.diff
Mon, Feb 24, 12:01
F3004292: D25817.1740484882.diff
Mon, Feb 24, 12:01
F3004270: D25817.1740484011.diff
Mon, Feb 24, 11:46
F2977766: D25817.1739653308.diff
Fri, Feb 14, 21:01
F2977765: D25817.1739653307.diff
Fri, Feb 14, 21:01
F2977723: D25817.1739649490.diff
Fri, Feb 14, 19:58
F2977697: D25817.1739645032.diff
Fri, Feb 14, 18:43

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Refs T15936

Test Plan

Read the code; compare to D25186.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable