Diffusion commit feed: avoid to repeat the commit message twice
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	valerio.bozzolan
	Jun 22 2023, 14:39

Description

In the Feed if there is a commit, its message can be mentioned twice: once in the title, once in the body.

Probably, it would be better to avoid to repeat the same phrase twice.

Diffusion feed before highlighted.png (307×718 px, 31 KB)

At the moment the content of the feed is generated by the Audit application, from:

PhabricatorAuditTransaction::getBodyForFeed()

https://we.phorge.it/source/phorge/browse/master/src/applications/audit/storage/PhabricatorAuditTransaction.php;a25af8ccef69de5978b0904866b028d96732202b$417-424

Proposals - only for the web feed:

✅ Proposal 1: clean the body

Current	Proposal

Removing the duplicate body may have more sense at the moment. So there is more creative space to then add a more useful body in the future.

⛔ Proposal 2: clean the title

Current	Proposal

🤔 Proposal 3: improving the body

Adding a more useful body would be interesting. But at the moment that would be a feature. Instead now we are just trying to fix a bug about duplicated texts.

Feel free to open a related task about improving the body. Probably this means improving the summary generator to be able to exclude the title and just show the next paragraph. But we have not that code right now.

Revisions and Commits

rP Phorge
	D25824	rP9acdd888930e Diffusion commit feed: fix commit title repeated twice

Related Objects
Search...

		Status	Assigned	Task
		Open	None	T15924 Commit feed body: it should probably show (part of) commit body
		Resolved	valerio.bozzolan	T15489 Diffusion commit feed: avoid to repeat the commit message twice

Event Timeline

valerio.bozzolan created this task.Jun 22 2023, 14:39

valerio.bozzolan triaged this task as Wishlist priority.

valerio.bozzolan created this object in space S1 Public.

Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptJun 22 2023, 14:39

valerio.bozzolan set the cover image to Restricted File.Jun 22 2023, 14:39

valerio.bozzolan moved this task from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.

valerio.bozzolan updated the task description. (Show Details)Jun 23 2023, 08:43

valerio.bozzolan updated the task description. (Show Details)Jun 23 2023, 09:06

I personally prefer option 1, so, removing the duplicate body. So there is more creative space to then add a more useful body in the future.

Premise: adding a more useful body right now seems too complicated and it probably deserves a dedicated task, since we probably have not an appropriate backend to do it at the moment. In fact, note that every single commit page shows the full commit message in a Remarkup area (including the title - so, also there the title is shown twice, in the body, and in the title).

valerio.bozzolan mentioned this in T15924: Commit feed body: it should probably show (part of) commit body.Aug 21 2024, 18:33

valerio.bozzolan added a parent task: T15924: Commit feed body: it should probably show (part of) commit body.

valerio.bozzolan claimed this task.Sep 14 2024, 13:54

valerio.bozzolan updated the task description. (Show Details)

valerio.bozzolan added a revision: D25824: Diffusion commit feed: fix commit title repeated twice.Sep 14 2024, 14:11

valerio.bozzolan moved this task from Code Sprint Candidate to PingDeath 🌚 on the User-valerio.bozzolan board.Sep 14 2024, 14:16

valerio.bozzolan closed this task as Resolved by committing rP9acdd888930e: Diffusion commit feed: fix commit title repeated twice.Sep 20 2024, 01:58

valerio.bozzolan added a commit: rP9acdd888930e: Diffusion commit feed: fix commit title repeated twice.

valerio.bozzolan mentioned this in Next Up.Sep 20 2024, 01:59