Page MenuHomePhorge
Create Task
Maniphest T15927

Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal
Closed, ResolvedPublic
Actions

Description

Steps to reproduce.

Have a terminal in a non-english language, like Italian, and:

arc unit src/parser/__tests__/ArcanistBundleTestCase.php

What happens:

EXCEPTION (Exception): Diff Parse Exception: Expected '\ No newline at end of file'.

             26    v
             27    w
             28    x
             29    y
             30    z
   >>>       31   \ Manca newline alla fine del file

What should happen instead:

$ LC_ALL=C arc unit src/parser/__tests__/ArcanistBundleTestCase.php
   PASS    5ms★  ArcanistBundleTestCase::testTrailingContext
   PASS    4ms★  ArcanistBundleTestCase::testMergeHunks
   PASS    2ms★  ArcanistBundleTestCase::testNonlocalTrailingNewline
   PASS    1ms★  ArcanistBundleTestCase::testEncodeBase85
   PASS   1.1s   ArcanistBundleTestCase::testGitRepository
   PASS    3ms★  ArcanistBundleTestCase::testDisjointHunks
   PASS   <1ms★  ArcanistBundleTestCase::testTabEncoding

Revisions and Commits

rARC Arcanist
D25809rARCb3d45c710414 ArcanistBundleTestCase: fix support of non-English environments

Related Objects
Search...

Event Timeline

valerio.bozzolan created this task.Aug 23 2024, 13:38
Herald added subscribers: Cigaryno, Matthew, chris, tobiaswiese. · View Herald TranscriptAug 23 2024, 13:38
valerio.bozzolan renamed this task from Fix Arcanist unit test - Diff Parse Exception: Expected '\ No newline at end of file' to Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.Aug 23 2024, 13:40
valerio.bozzolan triaged this task as Wishlist priority.
valerio.bozzolan updated the task description. (Show Details)
valerio.bozzolan mentioned this in D25799: Add missing variable names to PHPDoc @param of methods.
valerio.bozzolan added a revision: D25809: ArcanistBundleTestCase: fix support of non-English environments.Aug 26 2024, 14:23
valerio.bozzolan claimed this task.Sep 9 2024, 13:52
valerio.bozzolan added a subtask: T15872: Understand how to defuse localization in GNU Gettext.
valerio.bozzolan edited projects, added User-valerio.bozzolan; removed Bug Reports.
valerio.bozzolan mentioned this in D25809: ArcanistBundleTestCase: fix support of non-English environments.Oct 20 2024, 12:21
valerio.bozzolan added a comment.EditedOct 20 2024, 12:25

Has anybody a terminal with non-English environment and that obtains a non-English output with this command?

diff --help
...
Confronta i file riga per riga.

In my environment (Debian stable) it's in Italian. So I reproduce the issue. Note that Italian localization GNU Gettext files are provided as default in Debian.

https://packages.debian.org/bookworm/amd64/diffutils/filelist

And so it seems in Fedora

https://packages.fedoraproject.org/pkgs/diffutils/diffutils/fedora-41.html#files

So I think the proposed patch has sense, since it only does this:

LC_ALL=C diff --help
...
Compare FILES line by line.
mainframe98 subscribed.Oct 20 2024, 16:55

I can reproduce this (KDE on Debian 12, everything set to Dutch: LC_ALL evaluates to nl_NL.UTF-8). diff returns localized output, but doesn't when using LC_ALL=C.

valerio.bozzolan added a comment.Oct 21 2024, 05:34

Thanks, little cute Phorge kitten in profile picture <3

valerio.bozzolan closed this task as Resolved by committing rARCb3d45c710414: ArcanistBundleTestCase: fix support of non-English environments.Oct 21 2024, 05:35
valerio.bozzolan added a commit: rARCb3d45c710414: ArcanistBundleTestCase: fix support of non-English environments.
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0