Page MenuHomePhorge

Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal
Open, WishlistPublic

Description

Steps to reproduce.

Have a terminal in a non-english language, like Italian, and:

arc unit src/parser/__tests__/ArcanistBundleTestCase.php

What happens:

EXCEPTION (Exception): Diff Parse Exception: Expected '\ No newline at end of file'.

             26    v
             27    w
             28    x
             29    y
             30    z
   >>>       31   \ Manca newline alla fine del file

What should happen instead:

$ LC_ALL=C arc unit src/parser/__tests__/ArcanistBundleTestCase.php
   PASS    5ms★  ArcanistBundleTestCase::testTrailingContext
   PASS    4ms★  ArcanistBundleTestCase::testMergeHunks
   PASS    2ms★  ArcanistBundleTestCase::testNonlocalTrailingNewline
   PASS    1ms★  ArcanistBundleTestCase::testEncodeBase85
   PASS   1.1s   ArcanistBundleTestCase::testGitRepository
   PASS    3ms★  ArcanistBundleTestCase::testDisjointHunks
   PASS   <1ms★  ArcanistBundleTestCase::testTabEncoding

Event Timeline

valerio.bozzolan renamed this task from Fix Arcanist unit test - Diff Parse Exception: Expected '\ No newline at end of file' to Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.Fri, Aug 23, 13:40
valerio.bozzolan triaged this task as Wishlist priority.
valerio.bozzolan updated the task description. (Show Details)