Page MenuHomePhorge
Differential D25814

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic
Actions

Authored by aklapper on Aug 30 2024, 14:40.
Tags
None
Referenced Files
F2977228: D25814.1739625222.diff
Fri, Feb 14, 13:13
F2977227: D25814.1739625221.diff
Fri, Feb 14, 13:13
F2977201: D25814.1739621402.diff
Fri, Feb 14, 12:10
F2977193: D25814.1739620539.diff
Fri, Feb 14, 11:55
F2950686: D25814.1738813346.diff
Wed, Feb 5, 03:42
F2921776: D25814.1737558943.diff
Tue, Jan 21, 15:15
F2874975: D25814.1736968259.diff
Jan 14 2025, 19:10
F2874974: D25814.1736968259.diff
Jan 14 2025, 19:10
View All 13 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
chris
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated
Commits
rPdb61eb20f0f0: Fix implicitly nullable parameter declarations for PHP 8.4
Summary

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

Note: This code change does *not* fix all occurrences but only allows passing ./bin/storage upgrade.

Refs T15935

Test Plan

Try to successfully run ./bin/storage upgrade with PHP 8.4

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 30 2024, 14:40
Owners added a reviewer: O1: Blessed Committers.Aug 30 2024, 14:40
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 30 2024, 14:40
Harbormaster completed remote builds in B1575: Diff 2438.Aug 30 2024, 14:40
aklapper requested review of this revision.Aug 30 2024, 14:40
aklapper edited the summary of this revision. (Show Details)Aug 30 2024, 14:42
valerio.bozzolan edited the summary of this revision. (Show Details)Aug 30 2024, 14:57
aklapper mentioned this in D25816: Fix implicitly nullable parameter declarations for PHP 8.4.Aug 31 2024, 12:44
aklapper mentioned this in Z1: Phorge.Oct 18 2024, 12:23
chris accepted this revision.Oct 18 2024, 12:51
This revision is now accepted and ready to land.Oct 18 2024, 12:51
Closed by commit rPdb61eb20f0f0: Fix implicitly nullable parameter declarations for PHP 8.4. · Explain WhyOct 23 2024, 09:09
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPdb61eb20f0f0: Fix implicitly nullable parameter declarations for PHP 8.4.
aklapper mentioned this in rPf3d49f740737: Fix implicitly nullable parameter declarations for PHP 8.4.

Revision Contents
Changeset List

PathSizePackages
src/
applications/
audit/
storage/
4 linesO1: Blessed Committers
base/
2 linesO1: Blessed Committers
calendar/
storage/
12 linesO1: Blessed Committers
config/
schema/
4 linesO1: Blessed Committers
differential/
storage/
6 linesO1: Blessed Committers
4 linesO1: Blessed Committers
2 linesO1: Blessed Committers
4 linesO1: Blessed Committers
4 linesO1: Blessed Committers
diviner/
storage/
2 linesO1: Blessed Committers
4 linesO1: Blessed Committers
doorkeeper/
bridge/
2 linesO1: Blessed Committers
drydock/
storage/
2 linesO1: Blessed Committers
8 linesO1: Blessed Committers
files/
storage/
2 linesO1: Blessed Committers
2 linesO1: Blessed Committers
2 linesO1: Blessed Committers
fund/
storage/
2 linesO1: Blessed Committers
harbormaster/
storage/
build/
2 linesO1: Blessed Committers
2 linesO1: Blessed Committers
2 linesO1: Blessed Committers
legalpad/
storage/
2 linesO1: Blessed Committers
macro/
storage/
2 linesO1: Blessed Committers
maniphest/
storage/
2 linesO1: Blessed Committers
metamta/
storage/
2 linesO1: Blessed Committers
nuance/
storage/
2 linesO1: Blessed Committers
passphrase/
storage/
2 linesO1: Blessed Committers
people/
storage/
2 linesO1: Blessed Committers
phortune/
storage/
2 linesO1: Blessed Committers
2 linesO1: Blessed Committers
policy/
storage/
2 linesO1: Blessed Committers
ponder/
storage/
2 linesO1: Blessed Committers
project/
storage/
4 linesO1: Blessed Committers
2 linesO1: Blessed Committers
repository/
storage/
2 linesO1: Blessed Committers
6 linesO1: Blessed Committers
2 linesO1: Blessed Committers
settings/
storage/
2 linesO1: Blessed Committers
infrastructure/
daemon/
workers/
storage/
2 linesO1: Blessed Committers
storage/
lisk/
2 linesO1: Blessed Committers

Diff 2503

View Options

src/applications/audit/storage/PhabricatorAuditTransactionComment.php

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/config/schema/PhabricatorConfigSchemaQuery.php

Loading...
View Options

src/applications/differential/storage/DifferentialChangeset.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/differential/storage/DifferentialHunk.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransactionComment.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveBook.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveSymbol.php

Loading...
View Options

src/applications/doorkeeper/bridge/DoorkeeperBridgedObjectInterface.php

Loading...
View Options

src/applications/drydock/storage/DrydockLease.php

Loading...
View Options

src/applications/drydock/storage/DrydockLog.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

src/applications/files/storage/PhabricatorFileAttachment.php

Loading...
View Options

src/applications/files/storage/PhabricatorFileChunk.php

Loading...
View Options

src/applications/fund/storage/FundBacker.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php

Loading...
View Options

src/applications/legalpad/storage/LegalpadDocument.php

Loading...
View Options

src/applications/macro/storage/PhabricatorFileImageMacro.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

Loading...
View Options

src/applications/nuance/storage/NuanceItem.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
View Options

src/applications/people/storage/PhabricatorUserLog.php

Loading...
View Options

src/applications/phortune/storage/PhortuneCart.php

Loading...
View Options

src/applications/phortune/storage/PhortuneCharge.php

Loading...
View Options

src/applications/policy/storage/PhabricatorPolicy.php

Loading...
View Options

src/applications/ponder/storage/PonderAnswer.php

Loading...
View Options

src/applications/project/storage/PhabricatorProject.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectColumn.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryPullEvent.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php

Loading...
View Options

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0