Paths

Table of Contentst

Differential D25814

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic
Actions

Authored by aklapper on Aug 30 2024, 14:40.

Details

Reviewers

chris

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated

Commits

rPdb61eb20f0f0: Fix implicitly nullable parameter declarations for PHP 8.4

Summary

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

Note: This code change does *not* fix all occurrences but only allows passing ./bin/storage upgrade.

Refs T15935

Test Plan

Try to successfully run ./bin/storage upgrade with PHP 8.4

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 30 2024, 14:40

Owners added a reviewer: O1: Blessed Committers.Aug 30 2024, 14:40

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 30 2024, 14:40

Harbormaster completed remote builds in B1575: Diff 2438.Aug 30 2024, 14:40

aklapper requested review of this revision.Aug 30 2024, 14:40

aklapper edited the summary of this revision. (Show Details)Aug 30 2024, 14:42

valerio.bozzolan edited the summary of this revision. (Show Details)Aug 30 2024, 14:57

aklapper mentioned this in D25816: Fix implicitly nullable parameter declarations for PHP 8.4.Aug 31 2024, 12:44

aklapper mentioned this in Z1: Phorge.Oct 18 2024, 12:23

chris accepted this revision.Oct 18 2024, 12:51

This revision is now accepted and ready to land.Oct 18 2024, 12:51

Closed by commit rPdb61eb20f0f0: Fix implicitly nullable parameter declarations for PHP 8.4. · Explain WhyOct 23 2024, 09:09

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPdb61eb20f0f0: Fix implicitly nullable parameter declarations for PHP 8.4.

aklapper mentioned this in rPf3d49f740737: Fix implicitly nullable parameter declarations for PHP 8.4.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

audit/

storage/

PhabricatorAuditTransactionComment.php

4 lines

O1: Blessed Committers

base/

PhabricatorApplication.php

2 lines

O1: Blessed Committers

calendar/

storage/

PhabricatorCalendarEvent.php

12 lines

O1: Blessed Committers

config/

schema/

PhabricatorConfigSchemaQuery.php

4 lines

O1: Blessed Committers

differential/

storage/

DifferentialChangeset.php

6 lines

O1: Blessed Committers

DifferentialDiff.php

4 lines

O1: Blessed Committers

DifferentialHunk.php

2 lines

O1: Blessed Committers

DifferentialRevision.php

4 lines

O1: Blessed Committers

DifferentialTransactionComment.php

4 lines

O1: Blessed Committers

diviner/

storage/

DivinerLiveBook.php

2 lines

O1: Blessed Committers

DivinerLiveSymbol.php

4 lines

O1: Blessed Committers

doorkeeper/

bridge/

DoorkeeperBridgedObjectInterface.php

2 lines

O1: Blessed Committers

drydock/

storage/

DrydockLease.php

2 lines

O1: Blessed Committers

DrydockLog.php

8 lines

O1: Blessed Committers

files/

storage/

PhabricatorFile.php

2 lines

O1: Blessed Committers

PhabricatorFileAttachment.php

2 lines

O1: Blessed Committers

PhabricatorFileChunk.php

2 lines

O1: Blessed Committers

fund/

storage/

FundBacker.php

2 lines

O1: Blessed Committers

harbormaster/

storage/

build/

HarbormasterBuild.php

2 lines

O1: Blessed Committers

HarbormasterBuildLog.php

2 lines

O1: Blessed Committers

HarbormasterBuildTarget.php

2 lines

O1: Blessed Committers

legalpad/

storage/

LegalpadDocument.php

2 lines

O1: Blessed Committers

macro/

storage/

PhabricatorFileImageMacro.php

2 lines

O1: Blessed Committers

maniphest/

storage/

ManiphestTask.php

2 lines

O1: Blessed Committers

metamta/

storage/

PhabricatorMetaMTAReceivedMail.php

2 lines

O1: Blessed Committers

nuance/

storage/

NuanceItem.php

2 lines

O1: Blessed Committers

passphrase/

storage/

PassphraseCredential.php

2 lines

O1: Blessed Committers

people/

storage/

PhabricatorUserLog.php

2 lines

O1: Blessed Committers

phortune/

storage/

PhortuneCart.php

2 lines

O1: Blessed Committers

PhortuneCharge.php

2 lines

O1: Blessed Committers

policy/

storage/

PhabricatorPolicy.php

2 lines

O1: Blessed Committers

ponder/

storage/

PonderAnswer.php

2 lines

O1: Blessed Committers

project/

storage/

PhabricatorProject.php

4 lines

O1: Blessed Committers

PhabricatorProjectColumn.php

2 lines

O1: Blessed Committers

repository/

storage/

PhabricatorRepository.php

2 lines

O1: Blessed Committers

PhabricatorRepositoryCommit.php

6 lines

O1: Blessed Committers

PhabricatorRepositoryPullEvent.php

2 lines

O1: Blessed Committers

settings/

storage/

PhabricatorUserPreferences.php

2 lines

O1: Blessed Committers

infrastructure/

daemon/

workers/

storage/

PhabricatorWorkerTrigger.php

2 lines

O1: Blessed Committers

storage/

lisk/

PhabricatorLiskDAO.php

2 lines

O1: Blessed Committers

Diff 2503

View Options

src/applications/audit/storage/PhabricatorAuditTransactionComment.php

View Options

src/applications/base/PhabricatorApplication.php

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

View Options

src/applications/config/schema/PhabricatorConfigSchemaQuery.php

View Options

src/applications/differential/storage/DifferentialChangeset.php

View Options

src/applications/differential/storage/DifferentialDiff.php

View Options

src/applications/differential/storage/DifferentialHunk.php

View Options

src/applications/differential/storage/DifferentialRevision.php

View Options

src/applications/differential/storage/DifferentialTransactionComment.php

View Options

src/applications/diviner/storage/DivinerLiveBook.php

View Options

src/applications/diviner/storage/DivinerLiveSymbol.php

View Options

src/applications/doorkeeper/bridge/DoorkeeperBridgedObjectInterface.php

View Options

src/applications/drydock/storage/DrydockLease.php

View Options

src/applications/drydock/storage/DrydockLog.php

View Options

src/applications/files/storage/PhabricatorFile.php

View Options

src/applications/files/storage/PhabricatorFileAttachment.php

View Options

src/applications/files/storage/PhabricatorFileChunk.php

View Options

src/applications/fund/storage/FundBacker.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php

View Options

src/applications/legalpad/storage/LegalpadDocument.php

View Options

src/applications/macro/storage/PhabricatorFileImageMacro.php

View Options

src/applications/maniphest/storage/ManiphestTask.php

View Options

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

View Options

src/applications/nuance/storage/NuanceItem.php

View Options

src/applications/passphrase/storage/PassphraseCredential.php

View Options

src/applications/people/storage/PhabricatorUserLog.php

View Options

src/applications/phortune/storage/PhortuneCart.php

View Options

src/applications/phortune/storage/PhortuneCharge.php

View Options

src/applications/policy/storage/PhabricatorPolicy.php

View Options

src/applications/ponder/storage/PonderAnswer.php

View Options

src/applications/project/storage/PhabricatorProject.php

View Options

src/applications/project/storage/PhabricatorProjectColumn.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

View Options

src/applications/repository/storage/PhabricatorRepositoryPullEvent.php

View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php

View Options

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Fix implicitly nullable parameter declarations for PHP 8.4ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2503

src/applications/audit/storage/PhabricatorAuditTransactionComment.php

src/applications/base/PhabricatorApplication.php

src/applications/calendar/storage/PhabricatorCalendarEvent.php

src/applications/config/schema/PhabricatorConfigSchemaQuery.php

src/applications/differential/storage/DifferentialChangeset.php

src/applications/differential/storage/DifferentialDiff.php

src/applications/differential/storage/DifferentialHunk.php

src/applications/differential/storage/DifferentialRevision.php

src/applications/differential/storage/DifferentialTransactionComment.php

src/applications/diviner/storage/DivinerLiveBook.php

src/applications/diviner/storage/DivinerLiveSymbol.php

src/applications/doorkeeper/bridge/DoorkeeperBridgedObjectInterface.php

src/applications/drydock/storage/DrydockLease.php

src/applications/drydock/storage/DrydockLog.php

src/applications/files/storage/PhabricatorFile.php

src/applications/files/storage/PhabricatorFileAttachment.php

src/applications/files/storage/PhabricatorFileChunk.php

src/applications/fund/storage/FundBacker.php

src/applications/harbormaster/storage/build/HarbormasterBuild.php

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php

src/applications/legalpad/storage/LegalpadDocument.php

src/applications/macro/storage/PhabricatorFileImageMacro.php

src/applications/maniphest/storage/ManiphestTask.php

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

src/applications/nuance/storage/NuanceItem.php

src/applications/passphrase/storage/PassphraseCredential.php

src/applications/people/storage/PhabricatorUserLog.php

src/applications/phortune/storage/PhortuneCart.php

src/applications/phortune/storage/PhortuneCharge.php

src/applications/policy/storage/PhabricatorPolicy.php

src/applications/ponder/storage/PonderAnswer.php

src/applications/project/storage/PhabricatorProject.php

src/applications/project/storage/PhabricatorProjectColumn.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/repository/storage/PhabricatorRepositoryCommit.php

src/applications/repository/storage/PhabricatorRepositoryPullEvent.php

src/applications/settings/storage/PhabricatorUserPreferences.php

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic
Actions

Revision Contents
Changeset List