Is this only related to the "Authored on ..." field, as far as you can see?

This is becoming quite frustrating in my workplace in Torino. Let's start immersion mode.

The "Authored On" field is rendered here:

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/controller/DiffusionCommitController.php;9f07e5083dfa523c81126c0edf67a3360906b74a$632

It seems some lines above, the "author epoque" from PhabricatorRepositoryCommitData#getAuthorEpoque() is always empty for SVN, while it's populated correctly for git.

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/controller/DiffusionCommitController.php;9f07e5083dfa523c81126c0edf67a3360906b74a$626

Now. Surprisingly: the hovercard, instead, already works! and it already shows the date correctly 🤔

So. Probably the hovercard has correct business logic. Let's see its logic:

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php;9f07e5083dfa523c81126c0edf67a3360906b74a

So the hovercard reads the commit date from PhabricatorRepositoryCommit#getEpoch().

So... gotcha \o/ We have found the root cause:

• PhabricatorRepositoryCommitData#getAuthorEpoque() - this does not work in SVN
• PhabricatorRepositoryCommit#getEpoch() - this works in SVN and in git

In short:

Git has two dates (author date - "when was the commit pushed", and commit date "when was the commit committed")

SVN, instead, has just the "commit date" (not the author date).

So, instead of just showing the author date (that can be NULL in SVN), we should introduce a fallback on the commit date, to make both git users and SVN users and future esoteric SVCs happy.