Page MenuHomePhorge

Remove trivial cases of unreachable code
ClosedPublic

Authored by aklapper on Aug 24 2024, 08:49.
Tags
None
Referenced Files
F3772066: D25802.1745853470.diff
Sun, Apr 27, 15:17
F3762882: D25802.1745835805.diff
Sun, Apr 27, 10:23
F3754689: D25802.1745822304.diff
Sun, Apr 27, 06:38
F3733482: D25802.1745747431.diff
Sat, Apr 26, 09:50
F3657688: D25802.1745453062.diff
Wed, Apr 23, 00:04
F3657381: D25802.1745443515.diff
Tue, Apr 22, 21:25
F3503044: D25802.1744797726.diff
Tue, Apr 15, 10:02
F3387776: D25802.1744440759.diff
Fri, Apr 11, 06:52

Details

Summary

Static code analysis can detect Unreachable statement - code above always terminates.
The vast majority of occurrences in the Phorge codebase are due to an unreachable break within a case after a return or after an all-covering if/else.
All this noise makes it harder to spot real logic issues (there are some!), thus fix these trivial cases.

Test Plan

Examine the code; run static code analysis.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable