Paths

Table of Contentst

Replace invalid PHPDoc @return type boolean with bool
ClosedPublic
Actions

Authored by aklapper on Aug 21 2024, 12:06.

Tags

None

Referenced Files

	F2964008: D25795.1739277570.diff
	Mon, Feb 10, 12:39

	F2954750: D25795.1739014728.diff
	Fri, Feb 7, 11:38

	F2929187: D25795.1737654618.diff
	Jan 22 2025, 17:50

	F2926876: D25795.1737642521.diff
	Jan 22 2025, 14:28

	F2926875: D25795.1737642519.diff
	Jan 22 2025, 14:28

	F2926866: D25795.1737642126.diff
	Jan 22 2025, 14:22

	F2926863: D25795.1737641996.diff
	Jan 22 2025, 14:19

	F2923646: D25795.1737574684.diff
	Jan 21 2025, 19:38

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPb9fb8d789151: Replace invalid PHPDoc @return type boolean with bool

Summary

@return boolean is not a valid type thus use @return bool.

Test Plan

None.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 21 2024, 12:06

Owners added a reviewer: O1: Blessed Committers.Aug 21 2024, 12:06

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 21 2024, 12:06

aklapper requested review of this revision.Aug 21 2024, 12:06

Harbormaster completed remote builds in B1552: Diff 2403.Aug 21 2024, 12:06

yesyes

This revision is now accepted and ready to land.Aug 21 2024, 21:54

Closed by commit rPb9fb8d789151: Replace invalid PHPDoc @return type boolean with bool. · Explain WhyAug 22 2024, 09:17

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPb9fb8d789151: Replace invalid PHPDoc @return type boolean with bool.

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

parser/

PhutilURIHelper.php

2 lines

O1: Blessed Committers

Diff 2406

View Options

src/infrastructure/parser/PhutilURIHelper.php

Replace invalid PHPDoc @return type boolean with boolClosedPublicActions