Paths

Table of Contentst

Differential D25801

Fix PHP 8.1 "preg_match(null)" exception in XHPASTNode
ClosedPublic
Actions

Authored by aklapper on Fri, Aug 23, 11:14.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15926: PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests

Commits

rARCa0941059085e: Fix PHP 8.1 "preg_match(null)" exception in XHPASTNode

Summary

When $u is null, null is passed to preg_match() which is deprecated behavior since PHP 8.1.
Thus first check if $u === null.

ERROR 8192: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [/var/www/html/phorge/arcanist/src/parser/xhpast/api/XHPASTNode.php:243]

Refs T15926

Test Plan

Either read the code, or probably run something like arc unit on D25797?

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Fri, Aug 23, 11:14

Owners added a reviewer: O1: Blessed Committers.Fri, Aug 23, 11:14

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, Aug 23, 11:14

aklapper requested review of this revision.Fri, Aug 23, 11:14

Harbormaster completed remote builds in B1560: Diff 2416.Fri, Aug 23, 11:14

aklapper mentioned this in D25809: ArcanistBundleTestCase: fix support of non-English environments.Mon, Aug 26, 21:41

sgtm

This revision is now accepted and ready to land.Thu, Sep 5, 19:17

This revision was landed with ongoing or failed builds.Fri, Sep 6, 08:28

Closed by commit rARCa0941059085e: Fix PHP 8.1 "preg_match(null)" exception in XHPASTNode. · Explain Why

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARCa0941059085e: Fix PHP 8.1 "preg_match(null)" exception in XHPASTNode.

Revision Contents
Changeset List

Path

Size

Packages

src/

parser/

xhpast/

api/

XHPASTNode.php

2 lines

O1: Blessed Committers

Diff 2456

View Options

src/parser/xhpast/api/XHPASTNode.php

Fix PHP 8.1 "preg_match(null)" exception in XHPASTNodeClosedPublicActions