Page MenuHomePhorge

Remove unused *ParallelQueries() database connection methods
ClosedPublic

Authored by aklapper on Aug 16 2024, 15:08.

Details

Summary

executeParallelQueries() is never called as supportsParallelQueries() returns false both in AphrontDatabaseConnection and AphrontMySQLDatabaseConnection.
Thus remove this unused code which was intentionally meant for HHVM which does not support PHP>=7 anyway.

P.S. Dear Facebook, if you are using this, let us know. We don't want to hurt your legacy Phabricator installation.

Closes T15919

Test Plan

Grep for both functions.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This sounds like something that folks at Facebook were overriding / patching. But, the class is final so it's difficult to believe that really somebody is using this.

From the point of view of Phorge, your edit is appreciated. Thanks.

From the point of view of other unknown people: we don't know what you are doing, so, if you care about this dead code, please just chat a bit with us in Phorge 🌈 we don't bite.

lgtm

This revision is now accepted and ready to land.Sep 5 2024, 13:19
This revision was landed with ongoing or failed builds.Sep 9 2024, 13:51
This revision was automatically updated to reflect the committed changes.