Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase
ClosedPublic

Authored by aklapper on Aug 23 2024, 11:08.
Tags
None
Referenced Files
F4011758: D25800.1746626598.diff
Tue, May 6, 14:03
F3796870: D25800.1745928831.diff
Mon, Apr 28, 12:13
F3747347: D25800.1745770445.diff
Sat, Apr 26, 16:14
F3720250: D25800.1745704557.diff
Fri, Apr 25, 21:55
F3682175: D25800.1745569581.diff
Thu, Apr 24, 08:26
F3387719: D25800.1744440315.diff
Fri, Apr 11, 06:45
F3383117: D25800.1744382333.diff
Thu, Apr 10, 14:38
F3372350: D25800.1744249590.diff
Wed, Apr 9, 01:46

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/arcanist/src/parser/xhpast/__tests__/PHPASTParserTestCase.php:85]

Refs T15926

Test Plan

Either read the code, or probably run something like arc unit on D25797?

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable