Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase
ClosedPublic

Authored by aklapper on Aug 23 2024, 11:08.
Tags
None
Referenced Files
F3292406: D25800.1742892669.diff
Mon, Mar 24, 08:51
F3290682: D25800.1742870121.diff
Mon, Mar 24, 02:35
F3290013: D25800.1742857927.diff
Sun, Mar 23, 23:12
F3289369: D25800.1742844586.diff
Sun, Mar 23, 19:29
F3254915: D25800.1742488085.diff
Wed, Mar 19, 16:28
F3252173: D25800.1742389141.diff
Tue, Mar 18, 12:59
F3225386: D25800.1742112883.diff
Sat, Mar 15, 08:14
F3048603: D25800.1740974559.diff
Sun, Mar 2, 04:02

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/arcanist/src/parser/xhpast/__tests__/PHPASTParserTestCase.php:85]

Refs T15926

Test Plan

Either read the code, or probably run something like arc unit on D25797?

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable