In D25535#15480, @avivey wrote:

Maybe this is wild, but: should we consider removing the compiled xhpast.exe file from the repository, and host is externally?

Ty. I’m still confused how “limit” is required but doesn’t throw an error when not specified. Can address that later if needed.

Thanks. Premising that $body can be null and that's a feature

Not before time!

In D25731#21672, @aklapper wrote:

I don't favor implementing non-obvious behavior ("why does it sometimes do this but not always"). :)

In D25731#21664, @valerio.bozzolan wrote:

Since you helped a lot in D25774 - I'm not sure this is needed anymore. Maybe better to get better opinions. For example I found this a bit irritating for my archived Milestones.

An additional check to make milestone owners happy might be: look to see if the board shows at least one task. If not, proceed.

Since you helped a lot in D25774 - I'm not sure this is needed anymore. Maybe better to get better opinions. For example I found this a bit irritating for my archived Milestones.

Thanks aklapper. Seems good from our side @speck?

It seems to me that in general more information should be added to the main page: screenshots, main features, as is usually done in other large projects.

Supporting PHP 8.4 (currently planned for 2024-11-21) will require PHP syntax introduced in PHP 7.1 per T15935.

Note that above two patches only allow passing ./bin/storage upgrade but not to run Phorge. That would be a followup once these initial patches got in.

The hacky solution would be to duplicate the current diff block, and then hide the green text on one side and the red text on the other side.

Agree. But the best I can do is... adding a slider that, the more you scroll it, the more it hides the red text/green text... LOL

Untested but seems good to me, maybe nice to add a couple of

git rebase master

Good question. The documentation is not "super-opinionated" about this - https://we.phorge.it/book/contrib/article/unit_tests/

Open question is whether to replace loadAllWhere with loadOneWhere under the assumption that there are always either zero or one results.
That would definitely require adding null check though.

In D25807#21516, @valerio.bozzolan wrote:

P.S. try applying D25809 to check if the red unit test becomes green

P.S. try applying D25809 to check if the red unit test becomes green