Page MenuHomePhorge

PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.php
Closed, ResolvedPublic

Description

  1. PHP 8.3.10; Arcanist at 3f893c1484ec17adf3211fa014f9ef70bdeca837
  2. Run ./bin/arc unit --everything
  3. Something is still buggy with the current code, though that was probably supposed to be fixed already by D25374:
[2024-08-26 18:41:46] ERROR 8192: urlencode(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/arcanist/src/future/oauth/PhutilOAuth1Future.php:232]
arcanist(head=master, ref.master=3f893c1484ec)
  #0 urlencode(NULL) called at [<arcanist>/src/future/oauth/PhutilOAuth1Future.php:232]
  #1 PhutilOAuth1Future::signString(string) called at [<arcanist>/src/future/oauth/PhutilOAuth1Future.php:223]
  #2 PhutilOAuth1Future::sign(array) called at [<arcanist>/src/future/oauth/PhutilOAuth1Future.php:110]
  #3 PhutilOAuth1Future::getSignature() called at [<arcanist>/src/future/oauth/__tests__/PhutilOAuth1FutureTestCase.php:160]
  #4 PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples() called at [<arcanist>/src/unit/engine/phutil/PhutilTestCase.php:639]
  #5 PhutilTestCase::run() called at [<arcanist>/src/unit/engine/PhutilUnitTestEngine.php:69]
  #6 PhutilUnitTestEngine::run() called at [<arcanist>/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:148]
  #7 ArcanistConfigurationDrivenUnitTestEngine::run() called at [<arcanist>/src/workflow/ArcanistUnitWorkflow.php:170]
  #8 ArcanistUnitWorkflow::run() called at [<arcanist>/scripts/arcanist.php:427]

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.