From the text body:IMPORTANT: Share that patch to your DBA <snip>
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 8 2024
Sep 8 2024
Sep 7 2024
Sep 7 2024
Moah fixees
aklapper updated the test plan for D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
aklapper updated the test plan for D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix unit test failure in link-alternate
Nice catch, thanks! Sorry for this regression in unit tests
aklapper retitled D25820: Fix unit test failure in link-alternate from Update unit test link-alternate
Sep 6 2024
Sep 6 2024
keithzg added a comment to Q150: Any way to set default visibility on file uploads to Conpherence? (Answer 187).
Does appear fixed in latest master!
valerio.bozzolan added inline comments to rARC06028fad3c6a: Add return statements for PhutilChannelChannel::readBytes()/writeBytes().
Drop question mark suffix from optional PHPDoc @param types
@valerio.bozzolan: Thank you! I know this is super boring work, but it allows PHPStan to show other type/class issues which are currently hidden due to PHPStan barking earlier about that non-standard question mark when parsing those lines. :-/
aklapper closed T15882: When archiving a project, reset its default menu item to Profile, a subtask of T15886: Archived Projects: make them "more Archived" , as Wontfix.
aklapper closed T15882: When archiving a project, reset its default menu item to Profile as Wontfix.
I confirm with my hand on my heart that I've consumed my eyes inspecting every single line to be absolutely sure that this PHPDoc probably has a better meaning and will not cause nuclear implosions.
PHPDoc: Replace "@return this" with "@return $this"
In T15848#19430, @valerio.bozzolan wrote:I would like to better understand the root problem.
Why changing the current user agent should improve the situation?
dtf awarded Update From Phabricator a Mountain of Wealth token.
Fix PHP 8.1 "preg_match(null)" exception in XHPASTNode
aklapper committed rP9e6507d37aef: Fix exception handling in ConpherenceViewController::handleRequest().
Fix exception handling in ConpherenceViewController::handleRequest()
dtf awarded T15401: Make the Remarkup Help Page Extensible a Love token.
Sep 5 2024
Sep 5 2024
OK thanks (I need some rest)
RhinosF1 added a comment to D25758: Set base-uri as User-Agent for OAuth1 and Github authentication.
In D25758#21773, @valerio.bozzolan wrote:Maybe better to discuss a little bit in T15848: newOAuth1Future doesn't set a User-Agent since I'm curious but also confused
Not exactly sure what the confusion is. The patch and task are clear to me and solve the issue.
Moreover traditionally, the user agent is the name of the software, not the origin. So this could also deserve another comment about why we should replace the specific software name with a fixed origin. Premising that I agree that the current user agent may be re-discussed, to include more information, like, "Phorge", and the version of Phorge.
Actually no, user agents for automated tooling often includes some sort of contact email or website or link to a page describing the bot/tool. I think this should be treated like that.
Also, in case, maybe probably nice to have a getUserAgent(__CLASS__) method in parent class PhutilAuthAdapter()
@valerio.bozzolan: thats not what Andre says. He says another area of the code uses a terrible user agent and we should change that to a better one at the same time.
valerio.bozzolan accepted D25780: Fix exception handling in ConpherenceViewController::handleRequest().
valerio.bozzolan updated the test plan for D25780: Fix exception handling in ConpherenceViewController::handleRequest().
valerio.bozzolan requested changes to D25758: Set base-uri as User-Agent for OAuth1 and Github authentication.
Maybe better to discuss a little bit in T15848: newOAuth1Future doesn't set a User-Agent since I'm curious but also confused
I would like to better understand the root problem. I see that Cloudflare was showing a captcha to Phorge (what Phorge?). It seems it was because an user agent was missing. But aklapper said that we are already setting an user agent.
valerio.bozzolan added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.
I just discovered that sometime we can spawn warnings above the comment box.
güncelleme
(In general thanks and please do whatever needed change in PHPDoc but let's reduce the commits on single files for different PHPDoc changes; so if you have lot of warnings on a single file, just do them all thanksl
valerio.bozzolan added a comment to D25789: Remove unused *ParallelQueries() database connection methods.
This sounds like something that folks at Facebook were overriding / patching. But, the class is final so it's difficult to believe that really somebody is using this.
valerio.bozzolan updated the summary of D25789: Remove unused *ParallelQueries() database connection methods.
Correct PHPDoc @return value of methods that can return null
Leave out special case src/workflow/ArcanistWorkflow.php for now
aklapper closed T15912: PHP 8.1 "strlen(null)" exceptions creating OAuth provider, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
aklapper committed rPb4bc480817cd: Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider.
Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider
Sep 4 2024
Sep 4 2024
I'd prefer not to increase the diff to upstream (as a side effect of this very task) but instead to pull a more recent upstream version - see T15940.
valerio.bozzolan added a parent task for T15564: Allow yourself to be Invited in Imported Events: T15939: Calendar Import Invitees 2.0.
valerio.bozzolan added a parent task for T15803: Calendar Import: add field "Default Invitees": T15939: Calendar Import Invitees 2.0.
valerio.bozzolan updated the task description for T15938: Understand if Diffusion public identities could be used to expand Calendar invitees.
• THYDUX edited 2 auditor(s) for rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator., removed 1: Cigaryno; added 1: • THYDUX.
fix typos in documentation
add a bit of documentation - just because we can
• THYDUX awarded rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator. a Manufacturing Defect? token.
aklapper edited 2 auditor(s) for rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator., removed 1: • THYDUX; added 1: Cigaryno.
• THYDUX edited 2 auditor(s) for rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator., removed 1: Cigaryno; added 1: • THYDUX.
Remove trivial cases of unreachable code
Remove trivial cases of unreachable code
aklapper committed rP8c3a62d6afd0: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text
aklapper committed rARC201fc1d981a9: Correct parameter name of PhpunitTestEngine::parseTestResults().
Correct parameter name of PhpunitTestEngine::parseTestResults()
Remove unused PhutilConsoleProgressSink::getWidth()
valerio.bozzolan accepted D25817: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
aklapper requested review of D25817: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
Right, should have probably also covered that line in D25186 which is more or less the same...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0