Same behavior in old upstream thus not a regression:
- Go to https://we.phorge.it/diviner/query/all/
- Click on any Method in the listed query results.
- Get a 404 error.
For example, the method addFieldsToListViewItem links to the URI
https://we.phorge.it/book/dev/method/addFieldsToListViewItem/
but as every method, it is documented in a class under the URI
https://we.phorge.it/book/dev/class/PhabricatorCustomFieldList/#method/addFieldsToListViewItem
My initial assumption was that URIs of atoms get created in DivinerAtom::getURI() in https://we.phorge.it/source/phorge/browse/master/src/applications/diviner/atom/DivinerAtom.php$286 but running ./bin/diviner generate --clean made no difference (and I still have no clue where exactly that resulting URI is actually used).
Instead, the culprit seems to be purely in rendering (not in indexing) in DivinerLiveSymbol::getURI().
See also similar T15932: All file search results in Diviner are 404 URIs.
(For those diving into the code, note that context seems to be about namespaced code per unmerged https://secure.phabricator.com/D9791)