Paths

Table of Contentst

Differential D25813

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic
Actions

Authored by aklapper on Aug 30 2024, 14:37.

Details

Reviewers

chris

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated

Commits

rARC99e57a702164: Fix implicitly nullable parameter declarations for PHP 8.4

Summary

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

Refs T15935

Test Plan

Try to successfully run ./bin/storage upgrade with PHP 8.4

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 30 2024, 14:37

Owners added a reviewer: O1: Blessed Committers.Aug 30 2024, 14:37

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 30 2024, 14:37

aklapper requested review of this revision.Aug 30 2024, 14:37

Harbormaster completed remote builds in B1574: Diff 2437.Aug 30 2024, 14:37

aklapper edited the summary of this revision. (Show Details)Aug 30 2024, 14:57

aklapper mentioned this in Z1: Phorge.Fri, Oct 18, 12:23

chris accepted this revision.Fri, Oct 18, 12:50

This revision is now accepted and ready to land.Fri, Oct 18, 12:50

Closed by commit rARC99e57a702164: Fix implicitly nullable parameter declarations for PHP 8.4. · Explain WhyWed, Oct 23, 09:08

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC99e57a702164: Fix implicitly nullable parameter declarations for PHP 8.4.

Revision Contents
Changeset List

Path

Size

Packages

src/

utils/

utils.php

2 lines

O1: Blessed Committers

Diff 2502

View Options

Fix implicitly nullable parameter declarations for PHP 8.4ClosedPublicActions