Paths

Table of Contentst

Differential D25816

Fix implicitly nullable parameter declarations for PHP 8.4
Needs ReviewPublic
Actions

Authored by aklapper on Sat, Aug 31, 12:43.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated

Summary

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

This patch is a followup on top of D25814.

Refs T15935

Test Plan

Try to view a task in the browser
Try to run ./bin/auth recover on the CLI
Try to browse projects in the browser
Try to create a new project without a name in the browser

Diff Detail

Repository

rP Phorge

Branch

T15935php84part2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1586
Build 1586: arc lint + arc unit

Event Timeline

aklapper created this revision.Sat, Aug 31, 12:43

Owners added a reviewer: O1: Blessed Committers.Sat, Aug 31, 12:43

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, Aug 31, 12:43

aklapper requested review of this revision.Sat, Aug 31, 12:43

Harbormaster completed remote builds in B1577: Diff 2440.Sat, Aug 31, 12:43

aklapper edited the summary of this revision. (Show Details)Sat, Aug 31, 12:44

aklapper edited the test plan for this revision. (Show Details)Sat, Sep 7, 12:27

aklapper edited the test plan for this revision. (Show Details)

Moah fixees

Harbormaster completed remote builds in B1586: Diff 2463.Sat, Sep 7, 12:29

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

auth/

engine/

PhabricatorAuthSessionEngine.php

8 lines

O1: Blessed Committers

files/

storage/

PhabricatorFile.php

2 lines

50%

O1: Blessed Committers

project/

controller/

PhabricatorProjectController.php

2 lines

O1: Blessed Committers

repository/

storage/

PhabricatorRepository.php

2 lines

13%

O1: Blessed Committers

search/

engine/

PhabricatorProfileMenuItemViewList.php

2 lines

O1: Blessed Committers

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

4 lines

52%

O1: Blessed Committers

error/

PhabricatorApplicationTransactionValidationError.php

2 lines

71%

O1: Blessed Committers

view/

page/

menu/

PhabricatorMainMenuSearchView.php

2 lines

29%

O1: Blessed Committers

Diff 2463

View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

View Options

src/applications/files/storage/PhabricatorFile.php

View Options

src/applications/project/controller/PhabricatorProjectController.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/search/engine/PhabricatorProfileMenuItemViewList.php

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

View Options

src/applications/transactions/error/PhabricatorApplicationTransactionValidationError.php

View Options

src/view/page/menu/PhabricatorMainMenuSearchView.php

Fix implicitly nullable parameter declarations for PHP 8.4Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2463

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

src/applications/files/storage/PhabricatorFile.php

src/applications/project/controller/PhabricatorProjectController.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/search/engine/PhabricatorProfileMenuItemViewList.php

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

src/applications/transactions/error/PhabricatorApplicationTransactionValidationError.php

src/view/page/menu/PhabricatorMainMenuSearchView.php

Fix implicitly nullable parameter declarations for PHP 8.4
Needs ReviewPublic
Actions

Revision Contents
Changeset List