Oh, I have to land it… Let's see if I still remember how.

Thanks. Premising that I also don't like projects with "automagic getters" so I agree with you; here how every getter works in Phabricator/Phorge:

Also related: T15025

Change offset to optional as requested by speck

As usual I'm confused about the PHP magic which does not require defining the method PhabricatorRepositoryCommit::getEpoch() in its class or parent classes, but I assume you tested locally that your patch works, plus PhabricatorRepositoryCommit does have some calls already to $this->getEpoch(), so I'll accept - worst case would be the very same behavior as now.

@valerio.bozzolan Thanks, this unblocks a few more things on my list. I admit that I have not looked into the unit test failure here and I assume you understand it and that it is fine to merge this patch. :)

FYI T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal

Width overflow fixed

Remove unecessary comment

I personally prefer option 1, so, removing the duplicate body. So there is more creative space to then add a more useful body in the future.

Indeed, we seem to prefer throwing exceptions after if (!($foo instanceof PhutilSortVector)), or use assert_instances_of() on an array, using gettype() and get_class().

This is becoming quite frustrating in my workplace in Torino. Let's start immersion mode.

Ironically, adding missing variable names to @param lines increases the amount of errors in PHPStan output:

Don't remove some empty line

Accepting but please wait other comments - 2 weeks?

...but don't follow my tip, since the above thing forces to a specific class and it's different than the old and already-proposed behavior

I'm personally OK with this, premising that Phorge never used assert(), as far as I can see.

I agree with @waldyrious and I just want to add that, if somebody wants to add a button (and restore multi-line), here is probably the code:

Note that I have NOT properly tested this locally as I still have issues with my LDAP setup.

Confirming my suspicion on PHP 8.3 (while I'm still struggling to successfully bind locally).
As far as I can tell (well, I'm running into ldap_bind(): Unable to bind to server: Can't contact LDAP server after the patch above while my local LDAP server is running but that's nothing new triggered by the patch above), the patch above seems to work.