Remove unused methods from ConpherenceDurableColumnView
ClosedPublic
Actions

Authored by aklapper on Aug 16 2024, 06:46.

Tags

None

Referenced Files

	F3306631: D25784.1743130253.diff
	Thu, Mar 27, 02:50

	F3298945: D25784.1743012989.diff
	Tue, Mar 25, 18:16

	F3297239: D25784.1742983201.diff
	Tue, Mar 25, 10:00

	F3294860: D25784.1742946046.diff
	Mon, Mar 24, 23:40

	F3288446: D25784.1742828438.diff
	Sun, Mar 23, 15:00

	F3286723: D25784.1742814781.diff
	Sun, Mar 23, 11:13

	F3254891: D25784.1742488024.diff
	Wed, Mar 19, 16:27

	F3245690: D25784.1742188730.diff
	Sun, Mar 16, 05:18

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPe1e1570c1165: Remove unused methods from ConpherenceDurableColumnView

Summary

Calls to private methods ConpherenceDurableColumnView::buildStatusText() and ConpherenceDurableColumnView::buildSendButton() were removed in https://we.phorge.it/rP95d174956639aac7525d52368944edfff7cdb824

Test Plan

Grep the code; run static code analysis.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 16 2024, 06:46

Owners added a reviewer: O1: Blessed Committers.Aug 16 2024, 06:46

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2024, 06:46

aklapper requested review of this revision.Aug 16 2024, 06:46

Harbormaster completed remote builds in B1534: Diff 2379.Aug 16 2024, 06:46

sgtm

src/applications/conpherence/view/ConpherenceDurableColumnView.php
491	👀 wow. Useful in T15225

This revision is now accepted and ready to land.Aug 20 2024, 07:01

aklapper marked an inline comment as done.Aug 20 2024, 08:10

Closed by commit rPe1e1570c1165: Remove unused methods from ConpherenceDurableColumnView. · Explain WhyAug 20 2024, 08:11

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPe1e1570c1165: Remove unused methods from ConpherenceDurableColumnView.

aklapper mentioned this in D25822: Documentation: add article about Javelin DOM stuff.Sep 10 2024, 11:33

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

conpherence/

view/

ConpherenceDurableColumnView.php

19 lines

O1: Blessed Committers

Diff 2398

View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Remove unused methods from ConpherenceDurableColumnViewClosedPublicActions