PHP 8.2 strlen() null issues when arc-diffing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	arnold
	May 15 2023, 19:36

Description

PS. I've patched my Phorge instance to not crash on these deprecation warnings

a@c:~/builds/web(billing)$ arc diff master
Launching editor "emacsclient"...
Provide the details for a new revision, then save and exit.
Waiting for Emacs...
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
 PUSH STAGING  Pushing changes to staging area...


Enumerating objects: 42, done.
Counting objects: 100% (42/42), done.
Delta compression using up to 32 threads
Compressing objects: 100% (31/31), done.
Writing objects: 100% (31/31), 4.74 KiB | 1.58 MiB/s, done.
Total 31 (delta 25), reused 0 (delta 0), pack-reused 0
remote: PHP Deprecated:  strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38
remote: 
remote: Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38
remote: PHP Deprecated:  strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38
remote: 
remote: Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38
remote: PHP Deprecated:  strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38
remote: 
remote: Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38
remote: PHP Deprecated:  strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38
remote: 
remote: Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38
remote: PHP Deprecated:  strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38
remote: 
remote: Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /home/phd/phabricator/src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php on line 38
To ssh://phabricator.tdrhq.com:2222/source/web.git
 * [new tag]             d00d491f2e64b65f13f41d4a53e2c8c869b6b882 -> phabricator/base/17223
 * [new tag]             0ede473b3439a9092fbe01e789ed8d22d33466af -> phabricator/diff/17223

Revisions and Commits

rP Phorge
	D25779	rP3c5e43cccbf0 Fix PHP 8.1 "strlen(null)" exception in DiffusionGitRawDiffQuery

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Open	None	T15064 Make Phorge compatible with PHP 8.1/8.2/8.3/8.4
Resolved	aklapper	T15399 PHP 8.2 strlen() null issues when arc-diffing
		· · ·

Event Timeline

arnold created this task.May 15 2023, 19:36

Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptMay 15 2023, 19:36

avivey added a project: PHP 8 support.May 15 2023, 19:48

Just a clarification: can we reproduce these issues? Can that repository be shared, or part of it, to reproduce this?

Thanks :)

valerio.bozzolan mentioned this in Z1: Phorge.May 17 2023, 14:25

valerio.bozzolan updated the task description. (Show Details)May 17 2023, 14:29

Cigaryno renamed this task from strlen() null issues when arc-diffing with PHP 8.2 to PHP 8.2 strlen() null issues when arc-diffing.Jun 29 2023, 20:39

@arnold please tell us the steps to reproduce this error for clarification so that we can fix this bug or share part or the entire repository.

Do you need to be able to replicate it? The fault does seem rather obvious in the code -

In src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php newQueryFuture() we have:

$path = $drequest->getPath();
if (!strlen($path)) {
  $path = '.';
}

Clearly getPath is expected to return a string or a null here, so just replace the !strlen() with phutil_nonempty_string() and ask arnold to patch & test...

aklapper added a parent task: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.Aug 15 2024, 12:22

aklapper added a revision: D25779: Fix PHP 8.1 "strlen(null)" exception in DiffusionGitRawDiffQuery.Aug 15 2024, 12:33

aklapper closed this task as Resolved by committing rP3c5e43cccbf0: Fix PHP 8.1 "strlen(null)" exception in DiffusionGitRawDiffQuery.Aug 22 2024, 09:17

aklapper claimed this task.

aklapper added a commit: rP3c5e43cccbf0: Fix PHP 8.1 "strlen(null)" exception in DiffusionGitRawDiffQuery.