Paths

Table of Contentst

Differential D25792

Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception
ClosedPublic
Actions

Authored by aklapper on Aug 19 2024, 19:49.

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated

Commits

rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception

Summary

Per https://www.php.net/manual/en/function.ldap-connect.php the signature $conn = @ldap_connect($host, $this->port); is deprecated since PHP 8.3.
Thus pass a full LDAP URI as the only parameter.

ERROR 8192: Usage of ldap_connect with two arguments is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php:308]

Closes T15724

Test Plan

Set up LDAP as auth provider, try to log in.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 19 2024, 19:49

Owners added a reviewer: O1: Blessed Committers.Aug 19 2024, 19:49

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 19 2024, 19:49

Harbormaster completed remote builds in B1548: Diff 2396.Aug 19 2024, 19:49

aklapper requested review of this revision.Aug 19 2024, 19:49

Note that I have NOT properly tested this locally as I still have issues with my LDAP setup.

It might be slightly safer to use PhutilURI, but this is in any case a potentially-unsafe configuration.

This revision is now accepted and ready to land.Sun, Nov 24, 09:32

Closed by commit rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception. · Explain WhyTue, Nov 26, 13:05

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.

this unfortunately caused T15963: LDAP over TLS is broken :/

aklapper added a reverting change: D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".Mon, Dec 2, 00:28

aklapper added a reverting change: rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….Mon, Dec 2, 09:28

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

adapter/

PhutilLDAPAuthAdapter.php

9 lines

O1: Blessed Committers

Diff 2532

src/applications/auth/adapter/PhutilLDAPAuthAdapter.php

Loading...